Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2660293002: Show Page Info from Form-Not-Secure 'Learn more' link (Closed)

Created:
3 years, 10 months ago by estark
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Show Page Info from Form-Not-Secure 'Learn more' link Instead of directly opening a tab to the Help Center, the "Learn more" link should open the Page Info bubble. From there the user can click another link to open the Help Center, if they want. BUG=684682 TEST=Enable #enable-http-form-warning. Visit http://rsolomakhin.github.io. Fill out the Name/Password form and submit it and save the password. Go back to http://rsolomakhin.github.io and focus the Password field. Observe the "Login not secure" warning in the autofill dropdown and click it. Observe that the Page Info bubble opens down from the omnibox. Review-Url: https://codereview.chromium.org/2650033004 Cr-Commit-Position: refs/heads/master@{#446469} (cherry picked from commit c83163e85da7ed3dc54a0dd21bf1954f2643459c) Review-Url: https://codereview.chromium.org/2660293002 . Cr-Commit-Position: refs/branch-heads/2987@{#170} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e1e7d7ff6eed446848c90fee771487669ba4466f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -90 lines) Patch
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/autofill/chrome_autofill_client.cc View 3 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_commands.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 3 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm View 3 chunks +1 line, -19 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 3 chunks +1 line, -20 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/password_autofill_manager_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
estark
3 years, 10 months ago (2017-01-30 19:01:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1e7d7ff6eed446848c90fee771487669ba4466f.

Powered by Google App Engine
This is Rietveld 408576698