Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: components/password_manager/core/browser/password_autofill_manager_unittest.cc

Issue 2660293002: Show Page Info from Form-Not-Secure 'Learn more' link (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_autofill_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_autofill_manager_unittest.cc b/components/password_manager/core/browser/password_autofill_manager_unittest.cc
index b6d94f2b4654107022c5c639f216da98ed5227f4..713b83cd24bf89bc48060ee0d689bb016e0a4777 100644
--- a/components/password_manager/core/browser/password_autofill_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_autofill_manager_unittest.cc
@@ -619,8 +619,8 @@ TEST_F(PasswordAutofillManagerTest, ShowStandaloneNotSecureWarning) {
password_autofill_manager_->OnShowNotSecureWarning(base::i18n::RIGHT_TO_LEFT,
element_bounds);
- // Accepting the warning message should trigger a call to open the url and
- // hide the popup.
+ // Accepting the warning message should trigger a call to open an explanation
+ // of the message and hide the popup.
EXPECT_CALL(*autofill_client, ShowHttpNotSecureExplanation());
EXPECT_CALL(*autofill_client, HideAutofillPopup());
password_autofill_manager_->DidAcceptSuggestion(
@@ -680,8 +680,8 @@ TEST_F(PasswordAutofillManagerTest, NonSecurePasswordFieldHttpWarningMessage) {
dummy_key, base::i18n::RIGHT_TO_LEFT, test_username_,
autofill::IS_PASSWORD_FIELD, element_bounds);
- // Accepting the warning message should trigger a call to open the url and
- // hide the popup.
+ // Accepting the warning message should trigger a call to open an explanation
+ // of the message and hide the popup.
EXPECT_CALL(*autofill_client, ShowHttpNotSecureExplanation());
EXPECT_CALL(*autofill_client, HideAutofillPopup());
password_autofill_manager_->DidAcceptSuggestion(
@@ -736,8 +736,8 @@ TEST_F(PasswordAutofillManagerTest, NonSecureUsernameFieldHttpWarningMessage) {
password_autofill_manager_->OnShowPasswordSuggestions(
dummy_key, base::i18n::RIGHT_TO_LEFT, test_username_, 0, element_bounds);
- // Accepting the warning message should trigger a call to open the url and
- // hide the popup.
+ // Accepting the warning message should trigger a call to open an explanation
+ // of the message and hide the popup.
EXPECT_CALL(*autofill_client, ShowHttpNotSecureExplanation());
EXPECT_CALL(*autofill_client, HideAutofillPopup());
password_autofill_manager_->DidAcceptSuggestion(
« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698