Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view.cc

Issue 2660293002: Show Page Info from Form-Not-Secure 'Learn more' link (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_icon_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.cc b/chrome/browser/ui/views/location_bar/location_icon_view.cc
index 92e6e2d519736d6972b049c208360dd28bb6a195..d388e2fa9b8f2eb769d3cfd2b20393d15a02ba67 100644
--- a/chrome/browser/ui/views/location_bar/location_icon_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_icon_view.cc
@@ -4,7 +4,6 @@
#include "chrome/browser/ui/views/location_bar/location_icon_view.h"
-#include "chrome/browser/ssl/security_state_tab_helper.h"
#include "chrome/browser/ui/view_ids.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
@@ -12,14 +11,10 @@
#include "chrome/grit/theme_resources.h"
#include "components/grit/components_scaled_resources.h"
#include "components/omnibox/browser/omnibox_edit_model.h"
-#include "components/security_state/core/security_state.h"
-#include "content/public/browser/navigation_controller.h"
-#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/web_contents.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/views/controls/label.h"
-using content::NavigationEntry;
using content::WebContents;
LocationIconView::LocationIconView(const gfx::FontList& font_list,
@@ -106,21 +101,7 @@ bool LocationIconView::OnActivate(const ui::Event& event) {
WebContents* contents = location_bar_->GetWebContents();
if (!contents)
return false;
-
- // Important to use GetVisibleEntry to match what's showing in the omnibox.
- NavigationEntry* entry = contents->GetController().GetVisibleEntry();
- // The visible entry can be nullptr in the case of window.open("").
- if (!entry)
- return false;
-
- SecurityStateTabHelper* helper =
- SecurityStateTabHelper::FromWebContents(contents);
- DCHECK(helper);
- security_state::SecurityInfo security_info;
- helper->GetSecurityInfo(&security_info);
-
- location_bar_->delegate()->ShowWebsiteSettings(
- contents, entry->GetVirtualURL(), security_info);
+ location_bar_->delegate()->ShowWebsiteSettings(contents);
return true;
}
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.h ('k') | chrome/browser/ui/views/toolbar/toolbar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698