Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Issue 2659433002: Track Text Selection information in TextInputManager (OOPIF for Android) (Closed)

Created:
3 years, 11 months ago by EhsanK
Modified:
3 years, 11 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su, site_isolation_reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track Text Selection information in TextInputManager (OOPIF for Android) Currently, TextSelection information is directly tracked by the platform's RenderWidgetHostViewAndroid. This does not work with OOPIFs which have their own RWHVCFs. This CL will route the SelectionChanged updates through the TextInputManager and then notifies the platform's view about any change on the page. This has already been happening in other platforms: * Aura: https://codereview.chromium.org/2130133004 * Mac: https://codereview.chromium.org/2240553003 An interactive test related to text selection tracking for OOPIFs is is also enabled on all platformed now. BUG=578168, 602427, 602723 Review-Url: https://codereview.chromium.org/2659433002 Cr-Commit-Position: refs/heads/master@{#446317} Committed: https://chromium.googlesource.com/chromium/src/+/564566c072aa4cfd4f6e787a3c2d24179e4c2ce1

Patch Set 1 #

Patch Set 2 : Clean ups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -118 lines) Patch
M chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc View 2 chunks +42 lines, -42 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 chunks +29 lines, -32 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 4 chunks +0 lines, -25 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +12 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
EhsanK
Hello Charlie, Could you please take a look?
3 years, 11 months ago (2017-01-25 19:01:32 UTC) #8
Charlie Reis
Nice, LGTM. (Seems fine to push those down from RWHVBase to RWHVMac for now, and ...
3 years, 11 months ago (2017-01-25 21:10:48 UTC) #9
EhsanK
Thanks Charlie! I will fix the issue with redundant variables in Mac and perhaps even ...
3 years, 11 months ago (2017-01-26 14:09:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659433002/20001
3 years, 11 months ago (2017-01-26 14:10:09 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 14:14:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/564566c072aa4cfd4f6e787a3c2d...

Powered by Google App Engine
This is Rietveld 408576698