Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2659433002: Track Text Selection information in TextInputManager (OOPIF for Android) (Closed)
Patch Set: Clean ups Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index 08aad92bb6ced62ea4092f6b837ce1c84544c27d..f78bc0b8de7c20659b427a74e56d5615220f41ce 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -463,22 +463,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// Whether we are showing a context menu.
bool showing_context_menu_;
-// TODO(ekaramad): In aura, text selection tracking for IME is done through the
-// TextInputManager. We still need the following variables for other platforms.
-// Remove them when tracking is done by TextInputManager on all platforms
-// (https://crbug.com/578168 and https://crbug.com/602427).
-#if !defined(USE_AURA)
- // A buffer containing the text inside and around the current selection range.
- base::string16 selection_text_;
-
- // The offset of the text stored in |selection_text_| relative to the start of
- // the web page.
- size_t selection_text_offset_;
-
- // The current selection range relative to the start of the web page.
- gfx::Range selection_range_;
-#endif
-
// The scale factor of the display the renderer is currently on.
float current_device_scale_factor_;

Powered by Google App Engine
This is Rietveld 408576698