Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2659433002: Track Text Selection information in TextInputManager (OOPIF for Android) (Closed)
Patch Set: Clean ups Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc
index 11482ff5115d32feb1d58a22e2fd092ea1fc6c5f..8e8f79053e48d83defd45991ea86093e71bcf613 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.cc
+++ b/content/browser/renderer_host/render_widget_host_view_base.cc
@@ -37,10 +37,6 @@ RenderWidgetHostViewBase::RenderWidgetHostViewBase()
background_color_(SK_ColorWHITE),
mouse_locked_(false),
showing_context_menu_(false),
-#if !defined(USE_AURA)
- selection_text_offset_(0),
- selection_range_(gfx::Range::InvalidRange()),
-#endif
current_device_scale_factor_(0),
current_display_rotation_(display::Display::ROTATE_0),
text_input_manager_(nullptr),
@@ -138,18 +134,8 @@ float RenderWidgetHostViewBase::GetBottomControlsHeight() const {
void RenderWidgetHostViewBase::SelectionChanged(const base::string16& text,
size_t offset,
const gfx::Range& range) {
-// TODO(ekaramad): Use TextInputManager code paths for IME on other platforms.
-// Also, remove the following local variables when that happens
-// (https://crbug.com/578168 and https://crbug.com/602427).
-#if !defined(OS_ANDROID)
if (GetTextInputManager())
GetTextInputManager()->SelectionChanged(this, text, offset, range);
-#else
- selection_text_ = text;
- selection_text_offset_ = offset;
- selection_range_.set_start(range.start());
- selection_range_.set_end(range.end());
-#endif
}
gfx::Size RenderWidgetHostViewBase::GetRequestedRendererSize() const {
@@ -180,10 +166,6 @@ void RenderWidgetHostViewBase::SetShowingContextMenu(bool showing) {
}
base::string16 RenderWidgetHostViewBase::GetSelectedText() {
-// TODO(ekaramad): Use TextInputManager code paths for IME on other platforms.
-// Also, remove the following local variables when that happens
-// (https://crbug.com/578168 and https://crbug.com/602427).
-#if !defined(OS_ANDROID)
if (!GetTextInputManager())
return base::string16();
@@ -195,13 +177,6 @@ base::string16 RenderWidgetHostViewBase::GetSelectedText() {
return selection->text.substr(selection->range.GetMin() - selection->offset,
selection->range.length());
-#else
- if (!selection_range_.IsValid())
- return base::string16();
- return selection_text_.substr(
- selection_range_.GetMin() - selection_text_offset_,
- selection_range_.length());
-#endif
}
bool RenderWidgetHostViewBase::IsMouseLocked() {

Powered by Google App Engine
This is Rietveld 408576698