Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2659303004: Clear out the float-lists from a ruby base when moving its children (Closed)

Created:
3 years, 10 months ago by rhogan
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Clear out the float-lists from a ruby base when moving its children A follow up to https://codereview.chromium.org/2329863002 and https://codereview.chromium.org/2645473004. When moving children from one base to another clear down the float lists of all descendants - seems like 'it's the only way to be sure'. BUG=683104 Review-Url: https://codereview.chromium.org/2653113002 Cr-Commit-Position: refs/heads/master@{#446410} (cherry picked from commit fa2a16567af6fc774c0a9fe44fb53eb5135056b0) Review-Url: https://codereview.chromium.org/2659303004 . Cr-Commit-Position: refs/branch-heads/2987@{#173} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/47603830c84360e6074df0d3e6b1c74f99a4bd3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/float/rubybase-children-moved-crash-2.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/rubybase-children-moved-crash-2-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
rhogan
3 years, 10 months ago (2017-01-30 19:47:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
47603830c84360e6074df0d3e6b1c74f99a4bd3a.

Powered by Google App Engine
This is Rietveld 408576698