Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 2653113002: Clear out the float-lists from a ruby base when moving its children (Closed)

Created:
3 years, 11 months ago by rhogan
Modified:
3 years, 11 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear out the float-lists from a ruby base when moving its children A follow up to https://codereview.chromium.org/2329863002 and https://codereview.chromium.org/2645473004. When moving children from one base to another clear down the float lists of all descendants - seems like 'it's the only way to be sure'. BUG=683104 Review-Url: https://codereview.chromium.org/2653113002 Cr-Commit-Position: refs/heads/master@{#446410} Committed: https://chromium.googlesource.com/chromium/src/+/fa2a16567af6fc774c0a9fe44fb53eb5135056b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/float/rubybase-children-moved-crash-2.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/rubybase-children-moved-crash-2-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
rhogan
3 years, 11 months ago (2017-01-25 18:47:12 UTC) #7
eae
LGTM
3 years, 11 months ago (2017-01-25 22:55:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653113002/1
3 years, 11 months ago (2017-01-25 22:56:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220548)
3 years, 11 months ago (2017-01-26 03:33:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653113002/1
3 years, 11 months ago (2017-01-26 06:32:58 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220749)
3 years, 11 months ago (2017-01-26 07:57:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653113002/1
3 years, 11 months ago (2017-01-26 19:15:55 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 19:57:18 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa2a16567af6fc774c0a9fe44fb5...

Powered by Google App Engine
This is Rietveld 408576698