Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2329863002: Copy float list of ruby base when merging it with a sibling (Closed)

Created:
4 years, 3 months ago by rhogan
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy float list of ruby base when merging it with a sibling When merging two ruby bases ensure that the new base has a complete float list. A 2nd go at https://crrev.com/6f208d569f6bd2488f2f2f6f9004e54417f78782 BUG=619380, 624028, 644605, 644803 Committed: https://crrev.com/3453e2368a018544e7143e60afbc7a1454e848ed Cr-Commit-Position: refs/heads/master@{#424864}

Patch Set 1 #

Patch Set 2 : bug 619380 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -36 lines) Patch
M third_party/WebKit/LayoutTests/fast/block/float/float-reparent-during-detach-crash.html View 1 chunk +16 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 3 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
rhogan
4 years, 2 months ago (2016-10-12 18:49:19 UTC) #9
eae
Nice cleanup, thank you! LGTM
4 years, 2 months ago (2016-10-12 18:50:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329863002/1
4 years, 2 months ago (2016-10-12 18:51:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/85304) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-12 18:53:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329863002/20001
4 years, 2 months ago (2016-10-12 20:59:21 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 21:30:27 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:34:21 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3453e2368a018544e7143e60afbc7a1454e848ed
Cr-Commit-Position: refs/heads/master@{#424864}

Powered by Google App Engine
This is Rietveld 408576698