Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26592006: Avoid useless call to RefPtr::get() in the generated bindings code (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Avoid useless call to RefPtr::get() in the generated bindings code Avoid useless call to RefPtr::get() in the generated bindings code for null checks. R=haraken,arv BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8Float64Array.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestConstants.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCustomAccessors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestExtendedEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestMediaQueryListListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
7 years, 2 months ago (2013-10-09 17:01:25 UTC) #1
adamk
lgtm
7 years, 2 months ago (2013-10-09 17:58:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26592006/1
7 years, 2 months ago (2013-10-09 17:58:17 UTC) #3
arv (Not doing code reviews)
LGTM
7 years, 2 months ago (2013-10-09 17:59:40 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 20:01:58 UTC) #5
Message was sent while issue was closed. 
Change committed as 159258

Powered by Google App Engine
This is Rietveld 408576698