Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: Source/bindings/tests/results/V8TestObjectPython.cpp

Issue 26592006: Avoid useless call to RefPtr::get() in the generated bindings code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 This file is part of the Blink open source project. 2 This file is part of the Blink open source project.
3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY! 3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY!
4 4
5 This library is free software; you can redistribute it and/or 5 This library is free software; you can redistribute it and/or
6 modify it under the terms of the GNU Library General Public 6 modify it under the terms of the GNU Library General Public
7 License as published by the Free Software Foundation; either 7 License as published by the Free Software Foundation; either
8 version 2 of the License, or (at your option) any later version. 8 version 2 of the License, or (at your option) any later version.
9 9
10 This library is distributed in the hope that it will be useful, 10 This library is distributed in the hope that it will be useful,
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 { 393 {
394 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter"); 394 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
395 TestObjectPythonV8Internal::readonlyShadowRootAttributeAttributeGetter(name, info); 395 TestObjectPythonV8Internal::readonlyShadowRootAttributeAttributeGetter(name, info);
396 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution"); 396 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
397 } 397 }
398 398
399 static void readonlyArrayBufferAttributeAttributeGetter(v8::Local<v8::String> na me, const v8::PropertyCallbackInfo<v8::Value>& info) 399 static void readonlyArrayBufferAttributeAttributeGetter(v8::Local<v8::String> na me, const v8::PropertyCallbackInfo<v8::Value>& info)
400 { 400 {
401 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder()); 401 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
402 RefPtr<ArrayBuffer> result = imp->readonlyArrayBufferAttribute(); 402 RefPtr<ArrayBuffer> result = imp->readonlyArrayBufferAttribute();
403 if (result.get() && DOMDataStore::setReturnValueFromWrapper<V8ArrayBuffer>(i nfo.GetReturnValue(), result.get())) 403 if (result && DOMDataStore::setReturnValueFromWrapper<V8ArrayBuffer>(info.Ge tReturnValue(), result.get()))
404 return; 404 return;
405 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate()); 405 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate());
406 if (!wrapper.IsEmpty()) { 406 if (!wrapper.IsEmpty()) {
407 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyAr rayBufferAttribute", wrapper); 407 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyAr rayBufferAttribute", wrapper);
408 v8SetReturnValue(info, wrapper); 408 v8SetReturnValue(info, wrapper);
409 } 409 }
410 } 410 }
411 411
412 static void readonlyArrayBufferAttributeAttributeGetterCallback(v8::Local<v8::St ring> name, const v8::PropertyCallbackInfo<v8::Value>& info) 412 static void readonlyArrayBufferAttributeAttributeGetterCallback(v8::Local<v8::St ring> name, const v8::PropertyCallbackInfo<v8::Value>& info)
413 { 413 {
414 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter"); 414 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
415 TestObjectPythonV8Internal::readonlyArrayBufferAttributeAttributeGetter(name , info); 415 TestObjectPythonV8Internal::readonlyArrayBufferAttributeAttributeGetter(name , info);
416 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution"); 416 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
417 } 417 }
418 418
419 static void readonlyFloat32ArrayAttributeAttributeGetter(v8::Local<v8::String> n ame, const v8::PropertyCallbackInfo<v8::Value>& info) 419 static void readonlyFloat32ArrayAttributeAttributeGetter(v8::Local<v8::String> n ame, const v8::PropertyCallbackInfo<v8::Value>& info)
420 { 420 {
421 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder()); 421 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
422 RefPtr<Float32Array> result = imp->readonlyFloat32ArrayAttribute(); 422 RefPtr<Float32Array> result = imp->readonlyFloat32ArrayAttribute();
423 if (result.get() && DOMDataStore::setReturnValueFromWrapper<V8Float32Array>( info.GetReturnValue(), result.get())) 423 if (result && DOMDataStore::setReturnValueFromWrapper<V8Float32Array>(info.G etReturnValue(), result.get()))
424 return; 424 return;
425 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate()); 425 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate());
426 if (!wrapper.IsEmpty()) { 426 if (!wrapper.IsEmpty()) {
427 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyFl oat32ArrayAttribute", wrapper); 427 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyFl oat32ArrayAttribute", wrapper);
428 v8SetReturnValue(info, wrapper); 428 v8SetReturnValue(info, wrapper);
429 } 429 }
430 } 430 }
431 431
432 static void readonlyFloat32ArrayAttributeAttributeGetterCallback(v8::Local<v8::S tring> name, const v8::PropertyCallbackInfo<v8::Value>& info) 432 static void readonlyFloat32ArrayAttributeAttributeGetterCallback(v8::Local<v8::S tring> name, const v8::PropertyCallbackInfo<v8::Value>& info)
433 { 433 {
434 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter"); 434 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
435 TestObjectPythonV8Internal::readonlyFloat32ArrayAttributeAttributeGetter(nam e, info); 435 TestObjectPythonV8Internal::readonlyFloat32ArrayAttributeAttributeGetter(nam e, info);
436 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution"); 436 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
437 } 437 }
438 438
439 static void readonlyUint8ArrayAttributeAttributeGetter(v8::Local<v8::String> nam e, const v8::PropertyCallbackInfo<v8::Value>& info) 439 static void readonlyUint8ArrayAttributeAttributeGetter(v8::Local<v8::String> nam e, const v8::PropertyCallbackInfo<v8::Value>& info)
440 { 440 {
441 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder()); 441 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
442 RefPtr<Uint8Array> result = imp->readonlyUint8ArrayAttribute(); 442 RefPtr<Uint8Array> result = imp->readonlyUint8ArrayAttribute();
443 if (result.get() && DOMDataStore::setReturnValueFromWrapper<V8Uint8Array>(in fo.GetReturnValue(), result.get())) 443 if (result && DOMDataStore::setReturnValueFromWrapper<V8Uint8Array>(info.Get ReturnValue(), result.get()))
444 return; 444 return;
445 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate()); 445 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate());
446 if (!wrapper.IsEmpty()) { 446 if (!wrapper.IsEmpty()) {
447 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyUi nt8ArrayAttribute", wrapper); 447 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyUi nt8ArrayAttribute", wrapper);
448 v8SetReturnValue(info, wrapper); 448 v8SetReturnValue(info, wrapper);
449 } 449 }
450 } 450 }
451 451
452 static void readonlyUint8ArrayAttributeAttributeGetterCallback(v8::Local<v8::Str ing> name, const v8::PropertyCallbackInfo<v8::Value>& info) 452 static void readonlyUint8ArrayAttributeAttributeGetterCallback(v8::Local<v8::Str ing> name, const v8::PropertyCallbackInfo<v8::Value>& info)
453 { 453 {
454 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter"); 454 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
455 TestObjectPythonV8Internal::readonlyUint8ArrayAttributeAttributeGetter(name, info); 455 TestObjectPythonV8Internal::readonlyUint8ArrayAttributeAttributeGetter(name, info);
456 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution"); 456 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
457 } 457 }
458 458
459 static void readonlyTestInterfaceEmptyAttributeAttributeGetter(v8::Local<v8::Str ing> name, const v8::PropertyCallbackInfo<v8::Value>& info) 459 static void readonlyTestInterfaceEmptyAttributeAttributeGetter(v8::Local<v8::Str ing> name, const v8::PropertyCallbackInfo<v8::Value>& info)
460 { 460 {
461 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder()); 461 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
462 RefPtr<TestInterfaceEmpty> result = imp->readonlyTestInterfaceEmptyAttribute (); 462 RefPtr<TestInterfaceEmpty> result = imp->readonlyTestInterfaceEmptyAttribute ();
463 if (result.get() && DOMDataStore::setReturnValueFromWrapper<V8TestInterfaceE mpty>(info.GetReturnValue(), result.get())) 463 if (result && DOMDataStore::setReturnValueFromWrapper<V8TestInterfaceEmpty>( info.GetReturnValue(), result.get()))
464 return; 464 return;
465 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate()); 465 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate());
466 if (!wrapper.IsEmpty()) { 466 if (!wrapper.IsEmpty()) {
467 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyTe stInterfaceEmptyAttribute", wrapper); 467 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyTe stInterfaceEmptyAttribute", wrapper);
468 v8SetReturnValue(info, wrapper); 468 v8SetReturnValue(info, wrapper);
469 } 469 }
470 } 470 }
471 471
472 static void readonlyTestInterfaceEmptyAttributeAttributeGetterCallback(v8::Local <v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info) 472 static void readonlyTestInterfaceEmptyAttributeAttributeGetterCallback(v8::Local <v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
473 { 473 {
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
850 { 850 {
851 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter"); 851 TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
852 TestObjectPythonV8Internal::customElementsCallbacksReadonlyLongAttributeAttr ibuteGetter(name, info); 852 TestObjectPythonV8Internal::customElementsCallbacksReadonlyLongAttributeAttr ibuteGetter(name, info);
853 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution"); 853 TRACE_EVENT_SET_SAMPLING_STATE("V8", "Execution");
854 } 854 }
855 855
856 static void readonlyDocumentFragmentAttributeAttributeGetter(v8::Local<v8::Strin g> name, const v8::PropertyCallbackInfo<v8::Value>& info) 856 static void readonlyDocumentFragmentAttributeAttributeGetter(v8::Local<v8::Strin g> name, const v8::PropertyCallbackInfo<v8::Value>& info)
857 { 857 {
858 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder()); 858 TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
859 RefPtr<DocumentFragment> result = imp->readonlyDocumentFragmentAttribute(); 859 RefPtr<DocumentFragment> result = imp->readonlyDocumentFragmentAttribute();
860 if (result.get() && DOMDataStore::setReturnValueFromWrapper<V8DocumentFragme nt>(info.GetReturnValue(), result.get())) 860 if (result && DOMDataStore::setReturnValueFromWrapper<V8DocumentFragment>(in fo.GetReturnValue(), result.get()))
861 return; 861 return;
862 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate()); 862 v8::Handle<v8::Value> wrapper = toV8(result.get(), info.Holder(), info.GetIs olate());
863 if (!wrapper.IsEmpty()) { 863 if (!wrapper.IsEmpty()) {
864 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyDo cumentFragmentAttribute", wrapper); 864 V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readonlyDo cumentFragmentAttribute", wrapper);
865 v8SetReturnValue(info, wrapper); 865 v8SetReturnValue(info, wrapper);
866 } 866 }
867 } 867 }
868 868
869 static void readonlyDocumentFragmentAttributeAttributeGetterCallback(v8::Local<v 8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info) 869 static void readonlyDocumentFragmentAttributeAttributeGetterCallback(v8::Local<v 8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
870 { 870 {
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
981 981
982 bool V8TestObjectPython::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v8:: Isolate* isolate) 982 bool V8TestObjectPython::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v8:: Isolate* isolate)
983 { 983 {
984 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld) 984 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld)
985 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld) 985 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld)
986 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d); 986 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d);
987 } 987 }
988 988
989 v8::Handle<v8::Object> V8TestObjectPython::createWrapper(PassRefPtr<TestObjectPy thon> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate) 989 v8::Handle<v8::Object> V8TestObjectPython::createWrapper(PassRefPtr<TestObjectPy thon> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
990 { 990 {
991 ASSERT(impl.get()); 991 ASSERT(impl);
992 ASSERT(!DOMDataStore::containsWrapper<V8TestObjectPython>(impl.get(), isolat e)); 992 ASSERT(!DOMDataStore::containsWrapper<V8TestObjectPython>(impl.get(), isolat e));
993 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) { 993 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) {
994 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get()); 994 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get());
995 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have 995 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have
996 // the same object de-ref functions, though, so use that as the basis of the check. 996 // the same object de-ref functions, though, so use that as the basis of the check.
997 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction); 997 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction);
998 } 998 }
999 999
1000 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate); 1000 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate);
1001 if (UNLIKELY(wrapper.IsEmpty())) 1001 if (UNLIKELY(wrapper.IsEmpty()))
1002 return wrapper; 1002 return wrapper;
1003 1003
1004 installPerContextProperties(wrapper, impl.get(), isolate); 1004 installPerContextProperties(wrapper, impl.get(), isolate);
1005 V8DOMWrapper::associateObjectWithWrapper<V8TestObjectPython>(impl, &info, wr apper, isolate, WrapperConfiguration::Independent); 1005 V8DOMWrapper::associateObjectWithWrapper<V8TestObjectPython>(impl, &info, wr apper, isolate, WrapperConfiguration::Independent);
1006 return wrapper; 1006 return wrapper;
1007 } 1007 }
1008 1008
1009 void V8TestObjectPython::derefObject(void* object) 1009 void V8TestObjectPython::derefObject(void* object)
1010 { 1010 {
1011 fromInternalPointer(object)->deref(); 1011 fromInternalPointer(object)->deref();
1012 } 1012 }
1013 1013
1014 } // namespace WebCore 1014 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestObject.cpp ('k') | Source/bindings/tests/results/V8TestOverloadedConstructors.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698