Source/bindings/tests/results/V8TestOverloadedConstructors.cpp - Issue 26592006: Avoid useless call to RefPtr::get() in the generated bindings code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

Issue 26592006: Avoid useless call to RefPtr::get() in the generated bindings code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

diff --git a/Source/bindings/tests/results/V8TestOverloadedConstructors.cpp b/Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

index 5316b497761c730593dd562da9017f5ca2ab4348..a71878d9dac58eccc100ea1314363cbcc5c8e7a0 100644

--- a/Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

+++ b/Source/bindings/tests/results/V8TestOverloadedConstructors.cpp

@@ -199,7 +199,7 @@ bool V8TestOverloadedConstructors::HasInstanceInAnyWorld(v8::Handle<v8::Value> v

v8::Handle<v8::Object> V8TestOverloadedConstructors::createWrapper(PassRefPtr<TestOverloadedConstructors> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)

{

- ASSERT(impl.get());

+ ASSERT(impl);

ASSERT(!DOMDataStore::containsWrapper<V8TestOverloadedConstructors>(impl.get(), isolate));

if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) {

const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObject(impl.get());