Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: Source/bindings/tests/results/V8TestCustomAccessors.cpp

Issue 26592006: Avoid useless call to RefPtr::get() in the generated bindings code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 This file is part of the Blink open source project. 2 This file is part of the Blink open source project.
3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY! 3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY!
4 4
5 This library is free software; you can redistribute it and/or 5 This library is free software; you can redistribute it and/or
6 modify it under the terms of the GNU Library General Public 6 modify it under the terms of the GNU Library General Public
7 License as published by the Free Software Foundation; either 7 License as published by the Free Software Foundation; either
8 version 2 of the License, or (at your option) any later version. 8 version 2 of the License, or (at your option) any later version.
9 9
10 This library is distributed in the hope that it will be useful, 10 This library is distributed in the hope that it will be useful,
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 186
187 bool V8TestCustomAccessors::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v 8::Isolate* isolate) 187 bool V8TestCustomAccessors::HasInstanceInAnyWorld(v8::Handle<v8::Value> value, v 8::Isolate* isolate)
188 { 188 {
189 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld) 189 return V8PerIsolateData::from(isolate)->hasInstance(&info, value, MainWorld)
190 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld) 190 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, IsolatedWo rld)
191 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d); 191 || V8PerIsolateData::from(isolate)->hasInstance(&info, value, WorkerWorl d);
192 } 192 }
193 193
194 v8::Handle<v8::Object> V8TestCustomAccessors::createWrapper(PassRefPtr<TestCusto mAccessors> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate) 194 v8::Handle<v8::Object> V8TestCustomAccessors::createWrapper(PassRefPtr<TestCusto mAccessors> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
195 { 195 {
196 ASSERT(impl.get()); 196 ASSERT(impl);
197 ASSERT(!DOMDataStore::containsWrapper<V8TestCustomAccessors>(impl.get(), iso late)); 197 ASSERT(!DOMDataStore::containsWrapper<V8TestCustomAccessors>(impl.get(), iso late));
198 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) { 198 if (ScriptWrappable::wrapperCanBeStoredInObject(impl.get())) {
199 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get()); 199 const WrapperTypeInfo* actualInfo = ScriptWrappable::getTypeInfoFromObje ct(impl.get());
200 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have 200 // Might be a XXXConstructor::info instead of an XXX::info. These will b oth have
201 // the same object de-ref functions, though, so use that as the basis of the check. 201 // the same object de-ref functions, though, so use that as the basis of the check.
202 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction); 202 RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(actualInfo->derefObjectFunction == info.derefObjectFunction);
203 } 203 }
204 204
205 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate); 205 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &info, toInternalPointer(impl.get()), isolate);
206 if (UNLIKELY(wrapper.IsEmpty())) 206 if (UNLIKELY(wrapper.IsEmpty()))
207 return wrapper; 207 return wrapper;
208 208
209 installPerContextProperties(wrapper, impl.get(), isolate); 209 installPerContextProperties(wrapper, impl.get(), isolate);
210 V8DOMWrapper::associateObjectWithWrapper<V8TestCustomAccessors>(impl, &info, wrapper, isolate, WrapperConfiguration::Independent); 210 V8DOMWrapper::associateObjectWithWrapper<V8TestCustomAccessors>(impl, &info, wrapper, isolate, WrapperConfiguration::Independent);
211 return wrapper; 211 return wrapper;
212 } 212 }
213 213
214 void V8TestCustomAccessors::derefObject(void* object) 214 void V8TestCustomAccessors::derefObject(void* object)
215 { 215 {
216 fromInternalPointer(object)->deref(); 216 fromInternalPointer(object)->deref();
217 } 217 }
218 218
219 } // namespace WebCore 219 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestConstants.cpp ('k') | Source/bindings/tests/results/V8TestEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698