Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2658073003: Remove redundant argument being passed to didRecalcStyle (Closed)

Created:
3 years, 10 months ago by nainar
Modified:
3 years, 10 months ago
Reviewers:
esprehn, Bugs Nash
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, rwlbuis, sof, nessy, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant argument being passed to didRecalcStyle This patch removs an unused argument (StyleRecalcChange) to Element and other classes implementing didRecalcStyle. CL that added the function to be used is: https://chromium.googlesource.com/chromium/src/+/a08e0f58a0f6083552f619e9c88888b82d8de6b5%5E%21 It was used in SVGUseElement (thanks bugsnash@ for the investigation) BUG=595137 Review-Url: https://codereview.chromium.org/2658073003 Cr-Commit-Position: refs/heads/master@{#446864} Committed: https://chromium.googlesource.com/chromium/src/+/57e530fab3e3d9be05de503a6066bb89d5741bf1

Patch Set 1 #

Messages

Total messages: 21 (12 generated)
nainar
Bugs, PTAL? Thanks!
3 years, 10 months ago (2017-01-27 02:25:24 UTC) #3
Bugs Nash
On 2017/01/27 at 02:25:24, nainar wrote: > Bugs, > > PTAL? Thanks! lgtm. please add ...
3 years, 10 months ago (2017-01-27 02:28:18 UTC) #5
nainar
3 years, 10 months ago (2017-01-27 02:59:09 UTC) #8
Bugs Nash
On 2017/01/27 at 02:59:09, nainar wrote: > The CL that you've listed as introducing this ...
3 years, 10 months ago (2017-01-27 03:14:30 UTC) #9
nainar
Thanks for the followup, changed in description.
3 years, 10 months ago (2017-01-27 03:18:24 UTC) #11
Bugs Nash
On 2017/01/27 at 03:14:30, Bugs Nash wrote: > On 2017/01/27 at 02:59:09, nainar wrote: > ...
3 years, 10 months ago (2017-01-27 03:19:20 UTC) #12
esprehn
lgtm
3 years, 10 months ago (2017-01-27 22:59:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658073003/1
3 years, 10 months ago (2017-01-28 01:06:37 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 01:13:12 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/57e530fab3e3d9be05de503a6066...

Powered by Google App Engine
This is Rietveld 408576698