Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2658073003: Remove redundant argument being passed to didRecalcStyle (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 1917 matching lines...) Expand 10 before | Expand all | Expand 10 after
1928 // This can be seen when a child transitions from floating to 1928 // This can be seen when a child transitions from floating to
1929 // non-floating we have to take it into account for the first letter. 1929 // non-floating we have to take it into account for the first letter.
1930 updatePseudoElement(PseudoIdFirstLetter, 1930 updatePseudoElement(PseudoIdFirstLetter,
1931 childNeedsStyleRecalc() ? Force : change); 1931 childNeedsStyleRecalc() ? Force : change);
1932 1932
1933 clearChildNeedsStyleRecalc(); 1933 clearChildNeedsStyleRecalc();
1934 clearChildNeedsReattachLayoutTree(); 1934 clearChildNeedsReattachLayoutTree();
1935 } 1935 }
1936 1936
1937 if (hasCustomStyleCallbacks()) 1937 if (hasCustomStyleCallbacks())
1938 didRecalcStyle(change); 1938 didRecalcStyle();
1939 } 1939 }
1940 1940
1941 PassRefPtr<ComputedStyle> Element::propagateInheritedProperties( 1941 PassRefPtr<ComputedStyle> Element::propagateInheritedProperties(
1942 StyleRecalcChange change) { 1942 StyleRecalcChange change) {
1943 if (change != IndependentInherit) 1943 if (change != IndependentInherit)
1944 return nullptr; 1944 return nullptr;
1945 if (isPseudoElement()) 1945 if (isPseudoElement())
1946 return nullptr; 1946 return nullptr;
1947 if (needsStyleRecalc()) 1947 if (needsStyleRecalc())
1948 return nullptr; 1948 return nullptr;
(...skipping 1772 matching lines...) Expand 10 before | Expand all | Expand 10 after
3721 attrNode->detachFromElementWithValue(attr.value()); 3721 attrNode->detachFromElementWithValue(attr.value());
3722 } 3722 }
3723 3723
3724 removeAttrNodeList(); 3724 removeAttrNodeList();
3725 } 3725 }
3726 3726
3727 void Element::willRecalcStyle(StyleRecalcChange) { 3727 void Element::willRecalcStyle(StyleRecalcChange) {
3728 DCHECK(hasCustomStyleCallbacks()); 3728 DCHECK(hasCustomStyleCallbacks());
3729 } 3729 }
3730 3730
3731 void Element::didRecalcStyle(StyleRecalcChange) { 3731 void Element::didRecalcStyle() {
3732 DCHECK(hasCustomStyleCallbacks()); 3732 DCHECK(hasCustomStyleCallbacks());
3733 } 3733 }
3734 3734
3735 PassRefPtr<ComputedStyle> Element::customStyleForLayoutObject() { 3735 PassRefPtr<ComputedStyle> Element::customStyleForLayoutObject() {
3736 DCHECK(hasCustomStyleCallbacks()); 3736 DCHECK(hasCustomStyleCallbacks());
3737 return nullptr; 3737 return nullptr;
3738 } 3738 }
3739 3739
3740 void Element::cloneAttributesFromElement(const Element& other) { 3740 void Element::cloneAttributesFromElement(const Element& other) {
3741 if (hasRareData()) 3741 if (hasRareData())
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
4128 } 4128 }
4129 4129
4130 DEFINE_TRACE_WRAPPERS(Element) { 4130 DEFINE_TRACE_WRAPPERS(Element) {
4131 if (hasRareData()) { 4131 if (hasRareData()) {
4132 visitor->traceWrappers(elementRareData()); 4132 visitor->traceWrappers(elementRareData());
4133 } 4133 }
4134 ContainerNode::traceWrappers(visitor); 4134 ContainerNode::traceWrappers(visitor);
4135 } 4135 }
4136 4136
4137 } // namespace blink 4137 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.h ('k') | third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698