Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2658073003: Remove redundant argument being passed to didRecalcStyle (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights
7 * reserved. 7 * reserved.
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2010 Google Inc. All rights reserved. 9 * Copyright (C) 2010 Google Inc. All rights reserved.
10 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 10 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
(...skipping 1930 matching lines...) Expand 10 before | Expand all | Expand 10 after
1941 m_popup->show(); 1941 m_popup->show();
1942 if (AXObjectCache* cache = document().existingAXObjectCache()) 1942 if (AXObjectCache* cache = document().existingAXObjectCache())
1943 cache->didShowMenuListPopup(menuList); 1943 cache->didShowMenuListPopup(menuList);
1944 } 1944 }
1945 1945
1946 void HTMLSelectElement::hidePopup() { 1946 void HTMLSelectElement::hidePopup() {
1947 if (m_popup) 1947 if (m_popup)
1948 m_popup->hide(); 1948 m_popup->hide();
1949 } 1949 }
1950 1950
1951 void HTMLSelectElement::didRecalcStyle(StyleRecalcChange change) { 1951 void HTMLSelectElement::didRecalcStyle() {
1952 HTMLFormControlElementWithState::didRecalcStyle(change); 1952 HTMLFormControlElementWithState::didRecalcStyle();
1953 if (popupIsVisible()) 1953 if (popupIsVisible())
1954 m_popup->updateFromElement(PopupMenu::ByStyleChange); 1954 m_popup->updateFromElement(PopupMenu::ByStyleChange);
1955 } 1955 }
1956 1956
1957 void HTMLSelectElement::detachLayoutTree(const AttachContext& context) { 1957 void HTMLSelectElement::detachLayoutTree(const AttachContext& context) {
1958 HTMLFormControlElementWithState::detachLayoutTree(context); 1958 HTMLFormControlElementWithState::detachLayoutTree(context);
1959 if (m_popup) 1959 if (m_popup)
1960 m_popup->disconnectClient(); 1960 m_popup->disconnectClient();
1961 m_popupIsVisible = false; 1961 m_popupIsVisible = false;
1962 m_popup = nullptr; 1962 m_popup = nullptr;
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
2044 m_popupUpdater = nullptr; 2044 m_popupUpdater = nullptr;
2045 } 2045 }
2046 2046
2047 void HTMLSelectElement::didMutateSubtree() { 2047 void HTMLSelectElement::didMutateSubtree() {
2048 DCHECK(popupIsVisible()); 2048 DCHECK(popupIsVisible());
2049 DCHECK(m_popup); 2049 DCHECK(m_popup);
2050 m_popup->updateFromElement(PopupMenu::ByDOMChange); 2050 m_popup->updateFromElement(PopupMenu::ByDOMChange);
2051 } 2051 }
2052 2052
2053 } // namespace blink 2053 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698