WPT Export: trim lines from branch list, stage changes before committing

WPT Export: trim lines from branch list, stage changes before committing

Also change expected status code for delelting a branch from 200 to 204.

R=qyearsley@chromium.org
BUG=684294
Review-Url: https://codereview.chromium.org/2657523005
Cr-Commit-Position: refs/heads/master@{#445933}
Committed: https://chromium.googlesource.com/chromium/src/+/18f09e1964fa2efd789bd56f706e81ccb467b416

[qyearsley, 2017-01-24 18:30:57]

lgtm

This also could have been 2 or 3 separate CLs; since these are very small
changes, breaking them down wouldn't make reviewing much easier and would add a
little overhead, so this is fine; the advantage of breaking it into separate CLs
would be that each CL title would only say one thing.

https://codereview.chromium.org/2657523005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py (right):

https://codereview.chromium.org/2657523005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py:106: return data
Note, this could probably be unit-tested by making a unit test method that
overrides WPTGithub.request with a method returning a canned response, but the
benefit of such a test method is pretty small in this case.

[jeffcarp, 2017-01-24 22:11:51]

The CQ bit was checked by jeffcarp@chromium.org

[jeffcarp, 2017-01-24 22:11:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2657523005/#ps20001
(title: "Add unit test TODO")

[commit-bot: I haz the power, 2017-01-24 22:12:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 00:00:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:00:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jeffcarp, 2017-01-25 02:15:48]

The CQ bit was checked by jeffcarp@chromium.org

[jeffcarp, 2017-01-25 02:15:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2657523005/#ps40001
(title: "Fix unit test")

[commit-bot: I haz the power, 2017-01-25 02:16:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 03:48:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485310548907940,
"parent_rev": "f855b40902acc2b89ae360cac0eadd410bffd6a5", "commit_rev":
"18f09e1964fa2efd789bd56f706e81ccb467b416"}

[commit-bot: I haz the power, 2017-01-25 03:48:51]

Description was changed from

==========
WPT Export: trim lines from branch list, stage changes before committing

Also change expected status code for delelting a branch from 200 to 204.

R=qyearsley@chromium.org
BUG=684294
==========

to

==========
WPT Export: trim lines from branch list, stage changes before committing

Also change expected status code for delelting a branch from 200 to 204.

R=qyearsley@chromium.org
BUG=684294

Review-Url: https://codereview.chromium.org/2657523005
Cr-Commit-Position: refs/heads/master@{#445933}
Committed:
https://chromium.googlesource.com/chromium/src/+/18f09e1964fa2efd789bd56f706e...
==========

[commit-bot: I haz the power, 2017-01-25 03:48:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/18f09e1964fa2efd789bd56f706e...

[jeffcarp, 2017-01-25 19:40:00]

Oops forgot to publish my drafts (again)

https://codereview.chromium.org/2657523005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py (right):

https://codereview.chromium.org/2657523005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py:106: return data
On 2017/01/24 at 18:30:56, qyearsley wrote:
> Note, this could probably be unit-tested by making a unit test method that
overrides WPTGithub.request with a method returning a canned response, but the
benefit of such a test method is pretty small in this case.

I'll add a TODO.