Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1391)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py

Issue 2657523005: WPT Export: trim lines from branch list, stage changes before committing (Closed)
Patch Set: Fix unit test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
index e3f6b73a8967e2d1c37e6a508dec9dc2fd9e638c..4cc6fb82e0dc6fa747cb8bd94ea4b99e6acba51b 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
@@ -96,11 +96,12 @@ class WPTGitHub(object):
raise Exception('PR could not be merged: %d' % pull_request_number)
def delete_remote_branch(self, remote_branch_name):
+ # TODO(jeffcarp): Unit test this method
path = '/repos/w3c/web-platform-tests/git/refs/heads/%s' % remote_branch_name
data, status_code = self.request(path, method='DELETE')
- if status_code != 200:
+ if status_code != 204:
# TODO(jeffcarp): Raise more specific exception (create MergeError class?)
- raise Exception('PR could not be merged')
+ raise Exception('Received non-204 status code attempting to delete remote branch: {}'.format(status_code))
return data
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698