Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py

Issue 2657523005: WPT Export: trim lines from branch list, stage changes before committing (Closed)
Patch Set: Fix unit test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
index ceb7387763caadcdc9992bd45b1f4c52af09d95b..e0531707615781ac842197700360dadb352b15fb 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
@@ -70,7 +70,7 @@ class LocalWPT(object):
def all_branches(self):
"""Returns a list of local and remote branches."""
- return self.run(['git', 'branch', '-a']).splitlines()
+ return [s.strip() for s in self.run(['git', 'branch', '-a']).splitlines()]
def create_branch_with_patch(self, message, patch, author):
"""Commits the given patch and pushes to the upstream repo.
@@ -95,6 +95,7 @@ class LocalWPT(object):
# TODO(jeffcarp): Use git am -p<n> where n is len(CHROMIUM_WPT_DIR.split(/'))
# or something not off-by-one.
self.run(['git', 'apply', '-'], input=patch)
+ self.run(['git', 'add', '.'])
self.run(['git', 'commit', '--author', author, '-am', message])
self.run(['git', 'push', REMOTE_NAME, self.branch_name])
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698