Convert HistoryTabHelper to use the new navigation callbacks.

Convert HistoryTabHelper to use the new navigation callbacks.

Also fix redirect chain in NavigationHandle to include navigations starting with client side redirects. This matches the old API, which is necessary to make the tests pass after this conversion.

BUG=682002
Review-Url: https://codereview.chromium.org/2657323003
Cr-Commit-Position: refs/heads/master@{#448454}
Committed: https://chromium.googlesource.com/chromium/src/+/b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb

[jam, 2017-01-27 21:20:52]

Description was changed from

==========
Convert HistoryTabHelper to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert HistoryTabHelper to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-01-27 21:21:02]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 21:21:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-27 21:31:39]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 21:32:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 22:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 22:13:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-01-28 00:13:13]

Patchset #1 (id:1) has been deleted

[jam, 2017-01-28 00:13:39]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 00:14:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 00:55:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 00:55:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-01-30 06:24:21]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 06:24:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 08:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 08:31:20]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[jam, 2017-01-31 06:33:04]

Patchset #4 (id:80001) has been deleted

[jam, 2017-01-31 06:34:00]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 06:34:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-31 06:34:42]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-01-31 07:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 07:11:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-01-31 18:53:10]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 18:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 19:07:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:07:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2017-01-31 19:29:42]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-01-31 19:30:10]

Patchset #4 (id:120001) has been deleted

[jam, 2017-01-31 19:30:16]

Patchset #3 (id:100001) has been deleted

[commit-bot: I haz the power, 2017-01-31 19:30:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-31 20:24:22]

jam@chromium.org changed reviewers:
+ clamy@chromium.org

[jam, 2017-01-31 20:24:23]

https://codereview.chromium.org/2657323003/diff/140001/content/browser/frame_...
File content/browser/frame_host/navigation_handle_impl.cc (right):

https://codereview.chromium.org/2657323003/diff/140001/content/browser/frame_...
content/browser/frame_host/navigation_handle_impl.cc:485: if (transition_ &
ui::PAGE_TRANSITION_CLIENT_REDIRECT) {
this mirrors the logic in RenderFrameImpl::SendDidCommitProvisionalLoad, which
would go away once we switch to the new API

[jam, 2017-01-31 21:24:44]

Description was changed from

==========
Convert HistoryTabHelper to use the new navigation callbacks.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert HistoryTabHelper to use the new navigation callbacks.

Also fix redirect chain in NavigationHandle to include navigations starting with
client side redirects. This matches the old API, which is necessary to make the
tests pass after this conversion.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2017-01-31 21:37:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 21:37:35]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[jam, 2017-02-06 15:53:41]

jam@chromium.org changed reviewers:
+ nasko@chromium.org
- clamy@chromium.org

[jam, 2017-02-06 15:53:42]

->nasko

[nasko, 2017-02-06 19:07:53]

LGTM

https://codereview.chromium.org/2657323003/diff/140001/content/browser/frame_...
File content/browser/frame_host/navigation_handle_impl.cc (right):

https://codereview.chromium.org/2657323003/diff/140001/content/browser/frame_...
content/browser/frame_host/navigation_handle_impl.cc:486: // If the page
contained a client redirect (meta refresh, document.loc...),
nit: Don't use ..., spell out the whole word.

[jam, 2017-02-06 20:28:33]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 20:28:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-06 20:36:19]

The CQ bit was checked by jam@chromium.org

[jam, 2017-02-06 20:36:19]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2657323003/#ps180001
(title: "nit")

[commit-bot: I haz the power, 2017-02-06 20:37:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-02-06 21:58:05]

Description was changed from

==========
Convert HistoryTabHelper to use the new navigation callbacks.

Also fix redirect chain in NavigationHandle to include navigations starting with
client side redirects. This matches the old API, which is necessary to make the
tests pass after this conversion.

BUG=682002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Convert HistoryTabHelper to use the new navigation callbacks.

Also fix redirect chain in NavigationHandle to include navigations starting with
client side redirects. This matches the old API, which is necessary to make the
tests pass after this conversion.

BUG=682002
==========

[commit-bot: I haz the power, 2017-02-06 22:45:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 22:45:07]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jam, 2017-02-06 22:55:04]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-02-06 22:56:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 00:07:51]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1486421704813440,
"parent_rev": "b87e96cb4c70ec8ba1189c5c3e1f57c3cd74dc66", "commit_rev":
"b5d1a4a7757e1a2fdbf5bf1633436d0f363fc4cb"}

[commit-bot: I haz the power, 2017-02-07 00:08:27]

Description was changed from

==========
Convert HistoryTabHelper to use the new navigation callbacks.

Also fix redirect chain in NavigationHandle to include navigations starting with
client side redirects. This matches the old API, which is necessary to make the
tests pass after this conversion.

BUG=682002
==========

to

==========
Convert HistoryTabHelper to use the new navigation callbacks.

Also fix redirect chain in NavigationHandle to include navigations starting with
client side redirects. This matches the old API, which is necessary to make the
tests pass after this conversion.

BUG=682002

Review-Url: https://codereview.chromium.org/2657323003
Cr-Commit-Position: refs/heads/master@{#448454}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5d1a4a7757e1a2fdbf5bf163343...
==========

[commit-bot: I haz the power, 2017-02-07 00:08:28]

Committed patchset #5 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/b5d1a4a7757e1a2fdbf5bf163343...