Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2657323003: Convert HistoryTabHelper to use the new navigation callbacks. (Closed)
Patch Set: nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index a047b10686475e946f87bc5cd09d262fbb5026a3..4b1bd89edc252d09ef42281fd9448fcd639c6142 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -385,9 +385,16 @@ void NavigationRequest::CreateNavigationHandle(int pending_nav_entry_id) {
// TODO(nasko): Update the NavigationHandle creation to ensure that the
// proper values are specified for is_same_page.
FrameTreeNode* frame_tree_node = frame_tree_node_;
+
+ std::vector<GURL> redirect_chain;
+ if (!begin_params_.client_side_redirect_url.is_empty())
+ redirect_chain.push_back(begin_params_.client_side_redirect_url);
+ redirect_chain.push_back(common_params_.url);
+
std::unique_ptr<NavigationHandleImpl> navigation_handle =
NavigationHandleImpl::Create(
- common_params_.url, frame_tree_node_, !browser_initiated_,
+ common_params_.url, redirect_chain, frame_tree_node_,
+ !browser_initiated_,
false, // is_same_page
common_params_.navigation_start, pending_nav_entry_id,
false); // started_in_context_menu
« no previous file with comments | « content/browser/frame_host/navigation_handle_impl_unittest.cc ('k') | content/browser/frame_host/navigator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698