Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: content/public/browser/navigation_handle.cc

Issue 2657323003: Convert HistoryTabHelper to use the new navigation callbacks. (Closed)
Patch Set: nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/navigation_handle.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_handle.cc
diff --git a/content/public/browser/navigation_handle.cc b/content/public/browser/navigation_handle.cc
index fecbf178b409773cefe85798fe598a5c4112823e..bcdbdb97b199bb949da118d5bfcd64b7087178ad 100644
--- a/content/public/browser/navigation_handle.cc
+++ b/content/public/browser/navigation_handle.cc
@@ -28,16 +28,16 @@ NavigationHandle::CreateNavigationHandleForTesting(
bool committed,
net::Error error,
bool is_same_page) {
+ RenderFrameHostImpl* rfhi =
+ static_cast<RenderFrameHostImpl*>(render_frame_host);
std::unique_ptr<NavigationHandleImpl> handle_impl =
NavigationHandleImpl::Create(
- url, static_cast<RenderFrameHostImpl*>(render_frame_host)
- ->frame_tree_node(),
+ url, std::vector<GURL>(), rfhi->frame_tree_node(),
true, // is_renderer_initiated
is_same_page,
base::TimeTicks::Now(), 0,
false); // started_from_context_menu
- handle_impl->set_render_frame_host(
- static_cast<RenderFrameHostImpl*>(render_frame_host));
+ handle_impl->set_render_frame_host(rfhi);
if (error != net::OK)
handle_impl->set_net_error_code(error);
if (committed)
« no previous file with comments | « content/public/browser/navigation_handle.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698