Issue 265703008: Support deps for actions in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265703008: Support deps for actions in GN. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Support deps for actions in GN. Previously GN did not write out any ninja code for deps and datadeps. This patch adds that and also documentation for how deps work for actions. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267945

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -15 lines)			Patch
M	tools/gn/functions_target.cc	View	1	5 chunks	+20 lines, -0 lines	0 comments	Download
M	tools/gn/ninja_action_target_writer.cc	View	1	2 chunks	+23 lines, -1 line	0 comments	Download
M	tools/gn/ninja_action_target_writer_unittest.cc	View	1	5 chunks	+20 lines, -4 lines	0 comments	Download
M	tools/gn/ninja_binary_target_writer.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/gn/ninja_target_writer.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	tools/gn/ninja_target_writer.cc	View	1	2 chunks	+11 lines, -2 lines	0 comments	Download
M	tools/gn/ninja_target_writer_unittest.cc	View	1	4 chunks	+9 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 7 months ago (2014-05-02 22:37:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r267945 (presubmit successful).