tools/gn/ninja_binary_target_writer.cc - Issue 265703008: Support deps for actions in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_binary_target_writer.cc

Issue 265703008: Support deps for actions in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_binary_target_writer.cc

diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc

index cbc5ff6cb427c9abd8e63f3b5a82c0128db67e87..9cdd2a49ede15f4970af0792f1a171434dcd7f8e 100644

--- a/tools/gn/ninja_binary_target_writer.cc

+++ b/tools/gn/ninja_binary_target_writer.cc

@@ -146,7 +146,8 @@ void NinjaBinaryTargetWriter::WriteSources(

const Target::FileList& sources = target_->sources();

object_files->reserve(sources.size());

- std::string implicit_deps = WriteInputDepsStampAndGetDep();

+ std::string implicit_deps =

+ WriteInputDepsStampAndGetDep(std::vector<const Target*>());

for (size_t i = 0; i < sources.size(); i++) {

const SourceFile& input_file = sources[i];

« no previous file with comments | « tools/gn/ninja_action_target_writer_unittest.cc ('k') | tools/gn/ninja_target_writer.h » ('j') | no next file with comments »