Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tools/gn/ninja_target_writer.h

Issue 265703008: Support deps for actions in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer.h
diff --git a/tools/gn/ninja_target_writer.h b/tools/gn/ninja_target_writer.h
index 813c4bc0c039fc5d5da27e4df357a5f26050937f..51e3ba160463f8d75ee0cf3567eb8722eee22fd5 100644
--- a/tools/gn/ninja_target_writer.h
+++ b/tools/gn/ninja_target_writer.h
@@ -33,8 +33,10 @@ class NinjaTargetWriter {
// returns the string to be appended to source rules that encodes the
// order-only dependencies for the current target. This will include the "|"
// character so can just be appended to the source rules. If there are no
- // implicit dependencies, returns the empty string.
- std::string WriteInputDepsStampAndGetDep() const;
+ // implicit dependencies and no extra target dependencies passed in, returns
+ // the empty string.
+ std::string WriteInputDepsStampAndGetDep(
+ const std::vector<const Target*>& extra_hard_deps) const;
// Returns the FileTemplate constructed from the outputs variable. This is
// like FileTemplate::GetForTargetOutputs except this additionally trims the
« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698