Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: tools/gn/functions_target.cc

Issue 265703008: Support deps for actions in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/ninja_action_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/functions_target.cc
diff --git a/tools/gn/functions_target.cc b/tools/gn/functions_target.cc
index 86048376cac6a1ca05cd2258d9acc49f69864f48..becbbabf70067edd14ff9726d1844a26dce8f127 100644
--- a/tools/gn/functions_target.cc
+++ b/tools/gn/functions_target.cc
@@ -70,6 +70,14 @@ Value ExecuteGenericTarget(const char* target_type,
" reference the output or generated intermediate file directories,\n" \
" respectively.\n"
+#define ACTION_DEPS \
+ " The \"deps\" for an action will always be completed before any part\n" \
+ " of the action is run so it can depend on the output of previous\n" \
+ " steps. The \"datadeps\" will be built if the action is built, but\n" \
+ " may not have completed before all steps of the action are started.\n" \
+ " This can give additional parallelism in the build for runtime-only\n" \
+ " dependencies.\n"
+
const char kAction[] = "action";
const char kAction_HelpShort[] =
"action: Declare a target that runs a script a single time.";
@@ -80,6 +88,8 @@ const char kAction_Help[] =
" or more output files. If you want to run a script once for each of a\n"
" set of input files, see \"gn help action_foreach\".\n"
"\n"
+ "Inputs\n"
+ "\n"
" In an action the \"sources\" and \"source_prereqs\" are treated the\n"
" same: they're both input dependencies on script execution with no\n"
" special handling. If you want to pass the sources to your script, you\n"
@@ -92,6 +102,10 @@ const char kAction_Help[] =
" variable, and stuff like other Python files required to run your\n"
" script in the \"source_prereqs\" variable.\n"
"\n"
+ ACTION_DEPS
+ "\n"
+ "Outputs\n"
+ "\n"
" You should specify files created by your script by specifying them in\n"
" the \"outputs\".\n"
"\n"
@@ -145,6 +159,8 @@ const char kActionForEach_Help[] =
" of sources. If you want to run a script once that takes many files as\n"
" input, see \"gn help action\".\n"
"\n"
+ "Inputs\n"
+ "\n"
" The script will be run once per file in the \"sources\" variable. The\n"
" \"outputs\" variable should specify one or more files with a source\n"
" expansion pattern in it (see \"gn help source_expansion\"). The output\n"
@@ -156,6 +172,10 @@ const char kActionForEach_Help[] =
" listed in the \"source_prereqs\" variable. These files are treated as\n"
" dependencies of each script invocation.\n"
"\n"
+ ACTION_DEPS
+ "\n"
+ "Outputs\n"
+ "\n"
SCRIPT_EXECUTION_CONTEXT
"\n"
"File name handling\n"
« no previous file with comments | « no previous file | tools/gn/ninja_action_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698