Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2656913002: Don't show FormNotSecure warning on page load (Closed)

Created:
3 years, 11 months ago by elawrence
Modified:
3 years, 11 months ago
Reviewers:
Mathieu, sebsg, engedy, meacer
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, vabr+watchlistpasswordmanager_chromium.org, Aaron Boodman, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, viettrungluu+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, darin (slow to review), qsr+mojo_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show FormNotSecure warning on page load Previously, we showed the FormNotSecure warning popup on form fields if an autofill occurred on page load. This proved to be too glitchy, so it is being removed for the time being. The notice will still appear when the user interacts with the form fields. BUG=685213 Review-Url: https://codereview.chromium.org/2656913002 Cr-Commit-Position: refs/heads/master@{#446363} Committed: https://chromium.googlesource.com/chromium/src/+/09f615ca6182adcf1dff3e55465b5dfdf7f27260

Patch Set 1 : Skip FNS warning on load #

Messages

Total messages: 23 (13 generated)
elawrence
This CL reverts the part of an earlier CL (https://codereview.chromium.org/2604453003) that showed “FormNotSecure” UI on ...
3 years, 11 months ago (2017-01-26 01:29:29 UTC) #6
engedy
components/password_manager/ LGTM.
3 years, 11 months ago (2017-01-26 09:31:03 UTC) #9
Mathieu
lgtm
3 years, 11 months ago (2017-01-26 15:15:43 UTC) #10
sebsg
lgtm
3 years, 11 months ago (2017-01-26 15:20:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656913002/40001
3 years, 11 months ago (2017-01-26 15:24:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/351023)
3 years, 11 months ago (2017-01-26 15:31:21 UTC) #15
elawrence
@meacer- PTAL at the IPC removal in /components/autofill/content/common
3 years, 11 months ago (2017-01-26 15:42:28 UTC) #17
meacer
lgtm
3 years, 11 months ago (2017-01-26 17:26:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656913002/40001
3 years, 11 months ago (2017-01-26 17:29:49 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 17:36:06 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/09f615ca6182adcf1dff3e55465b...

Powered by Google App Engine
This is Rietveld 408576698