Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2656913002: Don't show FormNotSecure warning on page load (Closed)
Patch Set: Skip FNS warning on load Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/password_autofill_agent.h" 5 #include "components/autofill/content/renderer/password_autofill_agent.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 1260 matching lines...) Expand 10 before | Expand all | Expand 10 after
1271 if (form_data.wait_for_username) 1271 if (form_data.wait_for_username)
1272 return; 1272 return;
1273 1273
1274 for (auto element : elements) { 1274 for (auto element : elements) {
1275 blink::WebInputElement username_element = 1275 blink::WebInputElement username_element =
1276 !element.isPasswordField() ? element : password_to_username_[element]; 1276 !element.isPasswordField() ? element : password_to_username_[element];
1277 blink::WebInputElement password_element = 1277 blink::WebInputElement password_element =
1278 element.isPasswordField() 1278 element.isPasswordField()
1279 ? element 1279 ? element
1280 : web_input_to_password_info_[element].password_field; 1280 : web_input_to_password_info_[element].password_field;
1281 if (FillFormOnPasswordReceived( 1281 FillFormOnPasswordReceived(
1282 form_data, username_element, password_element, 1282 form_data, username_element, password_element,
1283 &field_value_and_properties_map_, 1283 &field_value_and_properties_map_,
1284 base::Bind(&PasswordValueGatekeeper::RegisterElement, 1284 base::Bind(&PasswordValueGatekeeper::RegisterElement,
1285 base::Unretained(&gatekeeper_)), 1285 base::Unretained(&gatekeeper_)),
1286 logger.get())) { 1286 logger.get());
1287 if (form_data.show_form_not_secure_warning_on_autofill)
1288 autofill_agent_->ShowNotSecureWarning(element);
1289 }
1290 } 1287 }
1291 } 1288 }
1292 1289
1293 void PasswordAutofillAgent::GetFillableElementFromFormData( 1290 void PasswordAutofillAgent::GetFillableElementFromFormData(
1294 int key, 1291 int key,
1295 const PasswordFormFillData& form_data, 1292 const PasswordFormFillData& form_data,
1296 RendererSavePasswordProgressLogger* logger, 1293 RendererSavePasswordProgressLogger* logger,
1297 std::vector<blink::WebInputElement>* elements) { 1294 std::vector<blink::WebInputElement>* elements) {
1298 DCHECK(elements); 1295 DCHECK(elements);
1299 bool ambiguous_or_empty_names = 1296 bool ambiguous_or_empty_names =
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
1522 PasswordAutofillAgent::GetPasswordManagerDriver() { 1519 PasswordAutofillAgent::GetPasswordManagerDriver() {
1523 if (!password_manager_driver_) { 1520 if (!password_manager_driver_) {
1524 render_frame()->GetRemoteInterfaces()->GetInterface( 1521 render_frame()->GetRemoteInterfaces()->GetInterface(
1525 mojo::MakeRequest(&password_manager_driver_)); 1522 mojo::MakeRequest(&password_manager_driver_));
1526 } 1523 }
1527 1524
1528 return password_manager_driver_; 1525 return password_manager_driver_;
1529 } 1526 }
1530 1527
1531 } // namespace autofill 1528 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698