Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2656913002: Don't show FormNotSecure warning on page load (Closed)
Patch Set: Skip FNS warning on load Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index a2bbaf123ab86cedef60006a52755d71ef40e64b..acb0e8dc32891c9ab2dd005a59e5d25383c83e76 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -16,7 +16,6 @@
#include "base/threading/platform_thread.h"
#include "build/build_config.h"
#include "components/autofill/core/browser/autofill_field.h"
-#include "components/autofill/core/browser/autofill_manager.h"
#include "components/autofill/core/browser/form_structure.h"
#include "components/autofill/core/common/form_data_predictions.h"
#include "components/autofill/core/common/password_form_field_prediction_map.h"
@@ -35,7 +34,6 @@
#include "components/password_manager/core/common/password_manager_pref_names.h"
#include "components/pref_registry/pref_registry_syncable.h"
#include "components/prefs/pref_service.h"
-#include "components/security_state/core/security_state.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
#if defined(OS_WIN)
@@ -782,16 +780,6 @@ void PasswordManager::Autofill(
InitPasswordFormFillData(form_for_autofill, best_matches, &preferred_match,
wait_for_username, OtherPossibleUsernamesEnabled(),
&fill_data);
- // Show a "Login not secure" warning if the experiment is enabled and the
- // top-level page is not secure.
- // TODO(estark): Verify that |origin| is the right URL to check here.
- // https://crbug.com/676706
- autofill::AutofillManager* autofill_manager =
- client_->GetAutofillManagerForMainFrame();
- fill_data.show_form_not_secure_warning_on_autofill =
- security_state::IsHttpWarningInFormEnabled() && autofill_manager &&
- !autofill_manager->client()->IsContextSecure(fill_data.origin);
-
if (logger)
logger->LogBoolean(Logger::STRING_WAIT_FOR_USERNAME, wait_for_username);
UMA_HISTOGRAM_BOOLEAN(
« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698