Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2656903006:
Add dummy V8 build args to prevent for the iOS build. (Closed)
DescriptionAdd dummy V8 build args to prevent for the iOS build.
This is to prevent unused build overrides on iOS where V8 is not used but the default_arg overrides in //.gn are still present.
Longer-term we should probably not warn for unused args in the dotfile and then these can be removed.
BUG=684096
TBR=sdefresne
Review-Url: https://codereview.chromium.org/2656903006
Cr-Commit-Position: refs/heads/master@{#446779}
Committed: https://chromium.googlesource.com/chromium/src/+/08d54e1ba0047c6b42710d99a3687caadbdc3df8
Patch Set 1 #Patch Set 2 : Fix #Patch Set 3 : Fix #Messages
Total messages: 19 (13 generated)
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Description was changed from ========== Add dummy V8 build args to prevent for the iOS build. This is to prevent unused build overrides on iOS where V8 is not used but the default_arg overrides in //.gn are still present. Longer-term we should probably not warn for unused args in the dotfile and then these can be removed. BUG=684096 ========== to ========== Add dummy V8 build args to prevent for the iOS build. This is to prevent unused build overrides on iOS where V8 is not used but the default_arg overrides in //.gn are still present. Longer-term we should probably not warn for unused args in the dotfile and then these can be removed. BUG=684096 TBR=sdefresne ==========
brettw@chromium.org changed reviewers: + sdefresne@chromium.org
The CQ bit was unchecked by brettw@chromium.org
The CQ bit was checked by brettw@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Fix
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
Fix
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485548443754100,
"parent_rev": "984f50b22fe3337804670907f0cb51ae6539b17f", "commit_rev":
"08d54e1ba0047c6b42710d99a3687caadbdc3df8"}
Message was sent while issue was closed.
Description was changed from ========== Add dummy V8 build args to prevent for the iOS build. This is to prevent unused build overrides on iOS where V8 is not used but the default_arg overrides in //.gn are still present. Longer-term we should probably not warn for unused args in the dotfile and then these can be removed. BUG=684096 TBR=sdefresne ========== to ========== Add dummy V8 build args to prevent for the iOS build. This is to prevent unused build overrides on iOS where V8 is not used but the default_arg overrides in //.gn are still present. Longer-term we should probably not warn for unused args in the dotfile and then these can be removed. BUG=684096 TBR=sdefresne Review-Url: https://codereview.chromium.org/2656903006 Cr-Commit-Position: refs/heads/master@{#446779} Committed: https://chromium.googlesource.com/chromium/src/+/08d54e1ba0047c6b42710d99a368... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/08d54e1ba0047c6b42710d99a368... |
