Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: ios/BUILD.gn

Issue 2656903006: Add dummy V8 build args to prevent for the iOS build. (Closed)
Patch Set: Fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 assert(!is_component_build, "component build is unsupported on iOS") 5 assert(!is_component_build, "component build is unsupported on iOS")
6 6
7 declare_args() { 7 declare_args() {
8 # Control whether cronet is build (this is usually set by the script 8 # Control whether cronet is build (this is usually set by the script
9 # components/cronet/tools/cr_cronet.py as cronet requires specific 9 # components/cronet/tools/cr_cronet.py as cronet requires specific
10 # gn args to build correctly). 10 # gn args to build correctly).
11 is_cronet_build = false 11 is_cronet_build = false
12
13 # TODO(brettw) bug 684096: Remove these. These are to prevent unused
14 # override warnings on iOS from the setting of the default_args in the
15 # toplevel //.gn file. Since iOS doesn't compile V8, GN complains that
16 # the overrides are never used.
17 v8_extra_library_files = []
18 v8_experimental_extra_library_files = []
19 v8_enable_gdbjit = false
20 v8_imminent_deprecation_warnings = false
12 } 21 }
13 22
23 # Prevent warnings for unused build args above.
24 assert(v8_extra_library_files != 0)
25 assert(v8_experimental_extra_library_files != 0)
26 assert(!v8_enable_gdbjit)
27 assert(!v8_imminent_deprecation_warnings)
28
14 # This list all targets that needs to be build as part of "gn_all" on iOS. 29 # This list all targets that needs to be build as part of "gn_all" on iOS.
15 # This list should generally only include executables, but since some code 30 # This list should generally only include executables, but since some code
16 # has not yet been upstreamed it will sometimes also include targets that 31 # has not yet been upstreamed it will sometimes also include targets that
17 # are not used upstream to ensure they are not broken inadvertently. 32 # are not used upstream to ensure they are not broken inadvertently.
18 group("all") { 33 group("all") {
19 testonly = true 34 testonly = true
20 if (is_cronet_build) { 35 if (is_cronet_build) {
21 deps = [ 36 deps = [
22 "//components/cronet/ios:cronet_package", 37 "//components/cronet/ios:cronet_package",
23 "//ios/crnet:crnet_framework", 38 "//ios/crnet:crnet_framework",
(...skipping 17 matching lines...) Expand all
41 "//ios/chrome/test/earl_grey:all_tests", 56 "//ios/chrome/test/earl_grey:all_tests",
42 "//ios/clean/chrome/test:all_tests", 57 "//ios/clean/chrome/test:all_tests",
43 "//ios/net:all_tests", 58 "//ios/net:all_tests",
44 "//ios/showcase:all_tests", 59 "//ios/showcase:all_tests",
45 "//ios/testing:all_tests", 60 "//ios/testing:all_tests",
46 "//ios/web:all_tests", 61 "//ios/web:all_tests",
47 "//ios/web/shell/test:all_tests", 62 "//ios/web/shell/test:all_tests",
48 ] 63 ]
49 } 64 }
50 } 65 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698