Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2450)

Unified Diff: ios/BUILD.gn

Issue 2656903006: Add dummy V8 build args to prevent for the iOS build. (Closed)
Patch Set: Fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/BUILD.gn
diff --git a/ios/BUILD.gn b/ios/BUILD.gn
index e4dc67fbd1a9f3fd0a0aa5568884e63526e91196..59c46dacad7e63cf5b7c8e532cdafb04c8ee17fe 100644
--- a/ios/BUILD.gn
+++ b/ios/BUILD.gn
@@ -9,8 +9,23 @@ declare_args() {
# components/cronet/tools/cr_cronet.py as cronet requires specific
# gn args to build correctly).
is_cronet_build = false
+
+ # TODO(brettw) bug 684096: Remove these. These are to prevent unused
+ # override warnings on iOS from the setting of the default_args in the
+ # toplevel //.gn file. Since iOS doesn't compile V8, GN complains that
+ # the overrides are never used.
+ v8_extra_library_files = []
+ v8_experimental_extra_library_files = []
+ v8_enable_gdbjit = false
+ v8_imminent_deprecation_warnings = false
}
+# Prevent warnings for unused build args above.
+assert(v8_extra_library_files != 0)
+assert(v8_experimental_extra_library_files != 0)
+assert(!v8_enable_gdbjit)
+assert(!v8_imminent_deprecation_warnings)
+
# This list all targets that needs to be build as part of "gn_all" on iOS.
# This list should generally only include executables, but since some code
# has not yet been upstreamed it will sometimes also include targets that
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698