Re-enable EarlGrey tests that check static error pages.

Re-enable EarlGrey tests that check static error pages.

Remove the check for there being no webview in the current webstate
when checking for an error page. This test previously used
webViewBelongingToWebController, which has been removed.

BUG=684987
Review-Url: https://codereview.chromium.org/2656863002
Cr-Commit-Position: refs/heads/master@{#446090}
Committed: https://chromium.googlesource.com/chromium/src/+/e0e9cc646db41360ecc38f8fb7b04e799218e928

[baxley, 2017-01-25 17:28:55]

Description was changed from

==========
Re-enable EarlGrey tests that check static error pages.

Remove the check for there being no webview in the current webstate
when checking for an error page.

BUG=684987
==========

to

==========
Re-enable EarlGrey tests that check static error pages.

Remove the check for there being no webview in the current webstate
when checking for an error page. This test previously used
webViewBelongingToWebController, which has been removed.

BUG=684987
==========

[baxley, 2017-01-25 17:40:03]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org, marq@chromium.org

[baxley, 2017-01-25 17:40:03]

baxley@chromium.org changed required reviewers:
+ marq@chromium.org

[baxley, 2017-01-25 17:40:04]

Mark,

Eugene was okay with this approach, but it looks like you converted some of
these tests to EarlGrey, and I wanted to verify if the checks I'm removing are
critical or were just ported from the old tests.

These tests used to check for there being no webview belonging to the web
controller. We removed that method, since we should be checking for webview in
webstate. However, the tests that used this check for an error page find no
webview belonging to the webcontroller, but they do find a webview in the
current webstate.

Now my question is, does any of that matter? Can we simply remove the check for
where the webview belongs (or doesn't belong), and rely upon the check for 
StaticHTMLViewControllerText?

[Eugene But (OOO till 7-30), 2017-01-25 17:42:39]

lgtm

[marq (ping after 24h), 2017-01-25 18:25:05]

LGTM

I much prefer the test just looking for expected text on screen instead of
expecting a webState. I don't recall why I ported them in this way; if they work
without that  test, and are more reliable, then absolutely I'm in favor of this.

[baxley, 2017-01-25 19:25:39]

The CQ bit was checked by baxley@chromium.org

[commit-bot: I haz the power, 2017-01-25 19:26:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 19:40:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485372339989040,
"parent_rev": "dee1e191b730bc624a6e126e0663b61a9ce165a8", "commit_rev":
"e0e9cc646db41360ecc38f8fb7b04e799218e928"}

[commit-bot: I haz the power, 2017-01-25 19:41:14]

Description was changed from

==========
Re-enable EarlGrey tests that check static error pages.

Remove the check for there being no webview in the current webstate
when checking for an error page. This test previously used
webViewBelongingToWebController, which has been removed.

BUG=684987
==========

to

==========
Re-enable EarlGrey tests that check static error pages.

Remove the check for there being no webview in the current webstate
when checking for an error page. This test previously used
webViewBelongingToWebController, which has been removed.

BUG=684987

Review-Url: https://codereview.chromium.org/2656863002
Cr-Commit-Position: refs/heads/master@{#446090}
Committed:
https://chromium.googlesource.com/chromium/src/+/e0e9cc646db41360ecc38f8fb7b0...
==========

[commit-bot: I haz the power, 2017-01-25 19:41:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e0e9cc646db41360ecc38f8fb7b0...