Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm

Issue 2656863002: Re-enable EarlGrey tests that check static error pages. (Closed)
Patch Set: remove comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
diff --git a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
index dc8981e90d60b377ab13b51ae9f9c1b6dc6f2282..266f54d508b8d23e7fcc397af27921b7bf175411 100644
--- a/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
+++ b/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
@@ -204,12 +204,7 @@ void SwitchToNormalMode() {
// Check that the error page is visible.
void CheckErrorPageIsVisible() {
- // The DNS error page is static HTML content, so it isn't part of the webview
- // owned by the webstate.
- id<GREYMatcher> webViewMatcher =
- web::WebViewInWebState(chrome_test_util::GetCurrentWebState());
- [[EarlGrey selectElementWithMatcher:webViewMatcher]
- assertWithMatcher:grey_nil()];
+ // The DNS error page is static HTML content.
NSString* const kError =
l10n_util::GetNSString(IDS_ERRORPAGES_HEADING_NOT_AVAILABLE);
[[EarlGrey
@@ -515,8 +510,7 @@ void SelectTabUsingUI(NSString* title) {
// Verify correct recording of metrics when the reloading of an evicted tab
// fails.
-// TODO(crbug.com/684987): Re-enable this test.
-- (void)DISABLED_testEvictedTabReloadFailure {
+- (void)testEvictedTabReloadFailure {
web::test::SetUpFileBasedHttpServer();
chrome_test_util::HistogramTester histogramTester;
FailureBlock failureBlock = ^(NSString* error) {
« no previous file with comments | « no previous file | ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698