Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: ios/chrome/browser/ui/error_page_egtest.mm

Issue 2656863002: Re-enable EarlGrey tests that check static error pages. (Closed)
Patch Set: remove comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/error_page_egtest.mm
diff --git a/ios/chrome/browser/ui/error_page_egtest.mm b/ios/chrome/browser/ui/error_page_egtest.mm
index 8864a80d37e24a03c6c4401604e66b3199b87c9b..7619bfc7ec1073464c72e46ea329ddf8b7e66163 100644
--- a/ios/chrome/browser/ui/error_page_egtest.mm
+++ b/ios/chrome/browser/ui/error_page_egtest.mm
@@ -44,10 +44,6 @@ using web::test::HttpServer;
- (void)checkErrorPageIsVisible {
// The DNS error page is static HTML content, so it isn't part of the webview
// owned by the webstate.
- id<GREYMatcher> webViewMatcher =
- web::WebViewInWebState(chrome_test_util::GetCurrentWebState());
- [[EarlGrey selectElementWithMatcher:webViewMatcher]
- assertWithMatcher:grey_nil()];
NSString* const kError =
l10n_util::GetNSString(IDS_ERRORPAGES_HEADING_NOT_AVAILABLE);
[[EarlGrey selectElementWithMatcher:StaticHtmlViewContainingText(kError)]
@@ -70,8 +66,7 @@ using web::test::HttpServer;
#pragma mark - tests
// Tests whether the error page is displayed for a bad URL.
-// TODO(crbug.com/684987): Re-enable this test.
-- (void)DISABLED_testErrorPage {
+- (void)testErrorPage {
std::unique_ptr<web::DataResponseProvider> provider(
new ErrorPageResponseProvider());
web::test::SetUpHttpServer(std::move(provider));
@@ -82,8 +77,7 @@ using web::test::HttpServer;
}
// Tests whether the error page is displayed if it is behind a redirect.
-// TODO(crbug.com/684987): Re-enable this test.
-- (void)DISABLED_testErrorPageRedirect {
+- (void)testErrorPageRedirect {
std::unique_ptr<web::DataResponseProvider> provider(
new ErrorPageResponseProvider());
web::test::SetUpHttpServer(std::move(provider));
« no previous file with comments | « ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698