DevTools: Move checkbox title element into Shadow DOM

DevTools: Move checkbox title element into Shadow DOM

BUG=685385
Review-Url: https://codereview.chromium.org/2656823004
Cr-Commit-Position: refs/heads/master@{#446559}
Committed: https://chromium.googlesource.com/chromium/src/+/66019590aaaba940c5fdd563f3e0c901122727d5

[einbinder, 2017-01-25 22:40:57]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2017-01-25 22:40:58]

ptal

[dgozman, 2017-01-26 23:28:56]

lgtm

https://codereview.chromium.org/2656823004/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2656823004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js:107:
label.classList.add('cursor-auto');
Why change this?

[einbinder, 2017-01-27 00:22:39]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-01-27 00:22:40]

https://codereview.chromium.org/2656823004/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2656823004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js:107:
label.classList.add('cursor-auto');
On 2017/01/26 at 23:28:56, dgozman wrote:
> Why change this?

The cursor-auto class is defined in the sources panel css. It doesn't effect the
textElement which is in the shadow dom.

[commit-bot: I haz the power, 2017-01-27 00:23:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 01:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 01:05:17]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[einbinder, 2017-01-27 01:45:41]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-01-27 01:46:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 03:06:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485481541043490, "parent_rev":
"019be38954d8e8e8c44094e9eadd9771dbe61e75", "commit_rev":
"66019590aaaba940c5fdd563f3e0c901122727d5"}

[commit-bot: I haz the power, 2017-01-27 03:06:41]

Description was changed from

==========
DevTools: Move checkbox title element into Shadow DOM

BUG=685385
==========

to

==========
DevTools: Move checkbox title element into Shadow DOM

BUG=685385

Review-Url: https://codereview.chromium.org/2656823004
Cr-Commit-Position: refs/heads/master@{#446559}
Committed:
https://chromium.googlesource.com/chromium/src/+/66019590aaaba940c5fdd563f3e0...
==========

[commit-bot: I haz the power, 2017-01-27 03:06:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66019590aaaba940c5fdd563f3e0...