third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js - Issue 2656823004: DevTools: Move checkbox title element into Shadow DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Issue 2656823004: DevTools: Move checkbox title element into Shadow DOM (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

index ef8aed6389eba681045fa65787b2f186f404147a..1eb71fd112d213160081d893022540bfe26f5207 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

@@ -1287,7 +1287,7 @@ UI.createCheckboxLabel = function(title, checked, subtitle) {

var element = createElement('label', 'dt-checkbox');

element.checkboxElement.checked = !!checked;

if (title !== undefined) {

- element.textElement = element.createChild('div', 'dt-checkbox-text');

+ element.textElement = element.shadowRoot.createChild('div', 'dt-checkbox-text');

element.textElement.textContent = title;

if (subtitle !== undefined) {

element.subtitleElement = element.textElement.createChild('div', 'dt-checkbox-subtitle');