third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js - Issue 2656823004: DevTools: Move checkbox title element into Shadow DOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2656823004: DevTools: Move checkbox title element into Shadow DOM (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/breakpointsList.css ('k') | third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

index 64526f5893249cf12124f47123b33a4cdc661867..f847a3a375d4cde7ed92d87fc2822f86c1816725 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

@@ -104,7 +104,7 @@ Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP

label.checkboxElement.addEventListener('click', this._checkboxClicked.bind(this, url), false);

element._checkboxElement = label.checkboxElement;

- label.textElement.classList.add('cursor-auto');

+ label.classList.add('cursor-auto');

dgozman 2017/01/26 23:28:56 Why change this?

einbinder 2017/01/27 00:22:40 The cursor-auto class is defined in the sources pa

label.textElement.addEventListener('dblclick', this._labelClicked.bind(this, url), false);

var currentElement = /** @type {?Element} */ (this.listElement.firstChild);