Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2656633004: DevTools: migrate v8 console client to the new API. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman1
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate v8 console client to the new API. BUG=682521 Review-Url: https://codereview.chromium.org/2656633004 Cr-Commit-Position: refs/heads/master@{#446370} Committed: https://chromium.googlesource.com/chromium/src/+/1cafd655e448abc99cb991c9a19663da6c86505d

Patch Set 1 #

Patch Set 2 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -41 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-clear-function-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-command-clear-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-tests-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-in-console-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 chunk +18 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
pfeldman
3 years, 11 months ago (2017-01-24 23:03:46 UTC) #2
dgozman
lgtm
3 years, 11 months ago (2017-01-24 23:09:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656633004/20001
3 years, 10 months ago (2017-01-26 16:15:42 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 17:47:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1cafd655e448abc99cb991c9a196...

Powered by Google App Engine
This is Rietveld 408576698