Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 2656633004: DevTools: migrate v8 console client to the new API. (Closed)
Patch Set: rebaselined Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
index 6e4ac06ed5acc82206ac4b9fbd80d9da47f25779..1b552c801b4e7eced63916a2f021f565190337ab 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
@@ -45,21 +45,26 @@ ThreadDebugger* ThreadDebugger::from(v8::Isolate* isolate) {
}
// static
-MessageLevel ThreadDebugger::consoleAPITypeToMessageLevel(
- v8_inspector::V8ConsoleAPIType type) {
- switch (type) {
- case v8_inspector::V8ConsoleAPIType::kDebug:
- return VerboseMessageLevel;
- case v8_inspector::V8ConsoleAPIType::kLog:
- case v8_inspector::V8ConsoleAPIType::kInfo:
- return InfoMessageLevel;
- case v8_inspector::V8ConsoleAPIType::kWarning:
- return WarningMessageLevel;
- case v8_inspector::V8ConsoleAPIType::kError:
- return ErrorMessageLevel;
+MessageLevel ThreadDebugger::v8MessageLevelToMessageLevel(
+ v8::Isolate::MessageErrorLevel level) {
+ MessageLevel result = InfoMessageLevel;
+ switch (level) {
+ case v8::Isolate::kMessageDebug:
+ result = VerboseMessageLevel;
+ break;
+ case v8::Isolate::kMessageWarning:
+ result = WarningMessageLevel;
+ break;
+ case v8::Isolate::kMessageError:
+ result = ErrorMessageLevel;
+ break;
+ case v8::Isolate::kMessageLog:
+ case v8::Isolate::kMessageInfo:
default:
- return InfoMessageLevel;
+ result = InfoMessageLevel;
+ break;
}
+ return result;
}
void ThreadDebugger::willExecuteScript(v8::Isolate* isolate, int scriptId) {

Powered by Google App Engine
This is Rietveld 408576698