Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Issue 2656633004: DevTools: migrate v8 console client to the new API. (Closed)
Patch Set: rebaselined Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/inspector/ThreadDebugger.h" 5 #include "core/inspector/ThreadDebugger.h"
6 6
7 #include "bindings/core/v8/SourceLocation.h" 7 #include "bindings/core/v8/SourceLocation.h"
8 #include "bindings/core/v8/V8Binding.h" 8 #include "bindings/core/v8/V8Binding.h"
9 #include "bindings/core/v8/V8DOMException.h" 9 #include "bindings/core/v8/V8DOMException.h"
10 #include "bindings/core/v8/V8DOMTokenList.h" 10 #include "bindings/core/v8/V8DOMTokenList.h"
(...skipping 27 matching lines...) Expand all
38 38
39 // static 39 // static
40 ThreadDebugger* ThreadDebugger::from(v8::Isolate* isolate) { 40 ThreadDebugger* ThreadDebugger::from(v8::Isolate* isolate) {
41 if (!isolate) 41 if (!isolate)
42 return nullptr; 42 return nullptr;
43 V8PerIsolateData* data = V8PerIsolateData::from(isolate); 43 V8PerIsolateData* data = V8PerIsolateData::from(isolate);
44 return data ? data->threadDebugger() : nullptr; 44 return data ? data->threadDebugger() : nullptr;
45 } 45 }
46 46
47 // static 47 // static
48 MessageLevel ThreadDebugger::consoleAPITypeToMessageLevel( 48 MessageLevel ThreadDebugger::v8MessageLevelToMessageLevel(
49 v8_inspector::V8ConsoleAPIType type) { 49 v8::Isolate::MessageErrorLevel level) {
50 switch (type) { 50 MessageLevel result = InfoMessageLevel;
51 case v8_inspector::V8ConsoleAPIType::kDebug: 51 switch (level) {
52 return VerboseMessageLevel; 52 case v8::Isolate::kMessageDebug:
53 case v8_inspector::V8ConsoleAPIType::kLog: 53 result = VerboseMessageLevel;
54 case v8_inspector::V8ConsoleAPIType::kInfo: 54 break;
55 return InfoMessageLevel; 55 case v8::Isolate::kMessageWarning:
56 case v8_inspector::V8ConsoleAPIType::kWarning: 56 result = WarningMessageLevel;
57 return WarningMessageLevel; 57 break;
58 case v8_inspector::V8ConsoleAPIType::kError: 58 case v8::Isolate::kMessageError:
59 return ErrorMessageLevel; 59 result = ErrorMessageLevel;
60 break;
61 case v8::Isolate::kMessageLog:
62 case v8::Isolate::kMessageInfo:
60 default: 63 default:
61 return InfoMessageLevel; 64 result = InfoMessageLevel;
65 break;
62 } 66 }
67 return result;
63 } 68 }
64 69
65 void ThreadDebugger::willExecuteScript(v8::Isolate* isolate, int scriptId) { 70 void ThreadDebugger::willExecuteScript(v8::Isolate* isolate, int scriptId) {
66 if (ThreadDebugger* debugger = ThreadDebugger::from(isolate)) 71 if (ThreadDebugger* debugger = ThreadDebugger::from(isolate))
67 debugger->v8Inspector()->willExecuteScript(isolate->GetCurrentContext(), 72 debugger->v8Inspector()->willExecuteScript(isolate->GetCurrentContext(),
68 scriptId); 73 scriptId);
69 } 74 }
70 75
71 void ThreadDebugger::didExecuteScript(v8::Isolate* isolate) { 76 void ThreadDebugger::didExecuteScript(v8::Isolate* isolate) {
72 if (ThreadDebugger* debugger = ThreadDebugger::from(isolate)) 77 if (ThreadDebugger* debugger = ThreadDebugger::from(isolate))
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 void ThreadDebugger::onTimer(TimerBase* timer) { 485 void ThreadDebugger::onTimer(TimerBase* timer) {
481 for (size_t index = 0; index < m_timers.size(); ++index) { 486 for (size_t index = 0; index < m_timers.size(); ++index) {
482 if (m_timers[index].get() == timer) { 487 if (m_timers[index].get() == timer) {
483 m_timerCallbacks[index](m_timerData[index]); 488 m_timerCallbacks[index](m_timerData[index]);
484 return; 489 return;
485 } 490 }
486 } 491 }
487 } 492 }
488 493
489 } // namespace blink 494 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698