Support cube map dest target for CopyTextureCHROMIUM extension

Support cube map dest target for CopyTextureCHROMIUM extension

DIRECT_DRAW path isn't available for cube map dest texture if it isn't
cube map complete. So, use DRAW_AND_COPY path in this scenario, i.e.
draw to a 2D intemediate texture first, then copy from the 2d texture to
the cube map dest texture.

Also, this CL makes DIRECT_COPY and DRAW_AND_COPY path work well for cube
map dest texture.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2656563002
Cr-Commit-Position: refs/heads/master@{#446940}
Committed: https://chromium.googlesource.com/chromium/src/+/88a4e827ea7c5066a990cef70eec165ef6f28c26

[qiankun, 2017-01-24 09:16:59]

Description was changed from

==========
Support cube map dest target for CopyTextureCHROMIUM extension

DIRECT_DRAW path isn't available for cube map dest texture if it isn't
cube map complete. So, use DRAW_AND_COPY path in this scenario, i.e.
draw to a 2D intemediate texture first, then copy from the 2d texture to
the cube map dest texture.

Also, this CL makes DIRECT_COPY and DRAW_AND_COPY path work well for cube
map dest texture.

BUG=612542
==========

to

==========
Support cube map dest target for CopyTextureCHROMIUM extension

DIRECT_DRAW path isn't available for cube map dest texture if it isn't
cube map complete. So, use DRAW_AND_COPY path in this scenario, i.e.
draw to a 2D intemediate texture first, then copy from the 2d texture to
the cube map dest texture.

Also, this CL makes DIRECT_COPY and DRAW_AND_COPY path work well for cube
map dest texture.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[qiankun, 2017-01-24 09:41:53]

qiankun.miao@intel.com changed reviewers:
+ kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2017-01-24 09:41:54]

PTAL.

[Zhenyao Mo, 2017-01-27 00:10:10]

On 2017/01/24 09:41:54, qiankun wrote:
> PTAL.

Very nice.

LGTM

[Zhenyao Mo, 2017-01-27 00:10:18]

https://codereview.chromium.org/2656563002/diff/1/gpu/command_buffer/tests/gl...
File gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc (right):

https://codereview.chromium.org/2656563002/diff/1/gpu/command_buffer/tests/gl...
gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc:412: // For cube
map textures, make the texture is cube complete.
nit: remove is.

[qiankun, 2017-01-29 14:09:03]

The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 14:09:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 15:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 15:26:15]

Dry run: This issue passed the CQ dry run.

[qiankun, 2017-01-29 15:39:16]

The CQ bit was checked by qiankun.miao@intel.com

[qiankun, 2017-01-29 15:39:17]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2656563002/#ps20001
(title: "fix nits")

[commit-bot: I haz the power, 2017-01-29 15:39:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qiankun, 2017-01-29 15:39:31]

https://codereview.chromium.org/2656563002/diff/1/gpu/command_buffer/tests/gl...
File gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc (right):

https://codereview.chromium.org/2656563002/diff/1/gpu/command_buffer/tests/gl...
gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc:412: // For cube
map textures, make the texture is cube complete.
On 2017/01/27 00:10:17, Zhenyao Mo wrote:
> nit: remove is.

Done.

[Yang Gu, 2017-01-29 15:39:38]

Yang is on vacation from Jan 24 to Feb 5 for Chinese New Year, so please expect
slow email response.

[commit-bot: I haz the power, 2017-01-29 15:43:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485704356879130,
"parent_rev": "5810aac4a8c8125ac42395661e7579d57552d059", "commit_rev":
"88a4e827ea7c5066a990cef70eec165ef6f28c26"}

[commit-bot: I haz the power, 2017-01-29 15:44:41]

Description was changed from

==========
Support cube map dest target for CopyTextureCHROMIUM extension

DIRECT_DRAW path isn't available for cube map dest texture if it isn't
cube map complete. So, use DRAW_AND_COPY path in this scenario, i.e.
draw to a 2D intemediate texture first, then copy from the 2d texture to
the cube map dest texture.

Also, this CL makes DIRECT_COPY and DRAW_AND_COPY path work well for cube
map dest texture.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Support cube map dest target for CopyTextureCHROMIUM extension

DIRECT_DRAW path isn't available for cube map dest texture if it isn't
cube map complete. So, use DRAW_AND_COPY path in this scenario, i.e.
draw to a 2D intemediate texture first, then copy from the 2d texture to
the cube map dest texture.

Also, this CL makes DIRECT_COPY and DRAW_AND_COPY path work well for cube
map dest texture.

BUG=612542
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2656563002
Cr-Commit-Position: refs/heads/master@{#446940}
Committed:
https://chromium.googlesource.com/chromium/src/+/88a4e827ea7c5066a990cef70eec...
==========

[commit-bot: I haz the power, 2017-01-29 15:44:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/88a4e827ea7c5066a990cef70eec...

[Ken Russell (switch to Gerrit), 2017-01-31 00:13:30]

Thank you Qiankun for pushing this forward! Excellent work!