Support cube map dest target for CopyTextureCHROMIUM extension

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
@@ skipping 16394 matching lines @@
   // INVALID_OPERATION is already generated by
   // ValidateCopyTextureCHROMIUMInternalFormats.
   if (method == NOT_COPYABLE) {
     return;
   }
 
   // Draw to a fbo attaching level 0 of an intermediate texture,
   // then copy from the fbo to dest texture level with glCopyTexImage2D.
   // For WebGL 1.0 or OpenGL ES 2.0, DIRECT_DRAW path isn't available for
   // dest_level > 0 due to level > 0 isn't supported by glFramebufferTexture2D
-  // in ES2 context. Go to DRAW_AND_COPY path in this case.
+  // in ES2 context. DIRECT_DRAW path isn't available for cube map dest texture
+  // either due to it may be cube map incomplete. Go to DRAW_AND_COPY path in
+  // these cases.
   // TODO(qiankun.miao@intel.com): for WebGL 2.0 or OpenGL ES 3.0, both
   // DIRECT_DRAW path for dest_level > 0 and DIRECT_COPY path for source_level >
   // 0 are not available due to a framebuffer completeness bug:
   // crbug.com/678526. Once the bug is fixed, the limitation for WebGL 2.0 and
   // OpenGL ES 3.0 can be lifted.
-  if ((dest_level > 0 && method == DIRECT_DRAW) ||
+  if (((dest_level > 0 || dest_binding_target == GL_TEXTURE_CUBE_MAP) &&
+       method == DIRECT_DRAW) ||
       (source_level > 0 && method == DIRECT_COPY)) {
     method = DRAW_AND_COPY;
   }
 
   if (feature_info_->feature_flags().desktop_srgb_support) {
     bool enable_framebuffer_srgb =
         GetColorEncodingFromInternalFormat(source_internal_format) == GL_SRGB ||
         GetColorEncodingFromInternalFormat(internal_format) == GL_SRGB;
     state_.EnableDisableFramebufferSRGB(enable_framebuffer_srgb);
   }
@@ skipping 237 matching lines @@
   // INVALID_OPERATION is already generated by
   // ValidateCopyTextureCHROMIUMInternalFormats.
   if (method == NOT_COPYABLE) {
     return;
   }
 
   // Draw to a fbo attaching level 0 of an intermediate texture,
   // then copy from the fbo to dest texture level with glCopyTexImage2D.
   // For WebGL 1.0 or OpenGL ES 2.0, DIRECT_DRAW path isn't available for
   // dest_level > 0 due to level > 0 isn't supported by glFramebufferTexture2D
-  // in ES2 context. Go to DRAW_AND_COPY path in this case.
+  // in ES2 context. DIRECT_DRAW path isn't available for cube map dest texture
+  // either due to it may be cube map incomplete. Go to DRAW_AND_COPY path in
+  // these cases.
   // TODO(qiankun.miao@intel.com): for WebGL 2.0 or OpenGL ES 3.0, both
   // DIRECT_DRAW path for dest_level > 0 and DIRECT_COPY path for source_level >
   // 0 are not available due to a framebuffer completeness bug:
   // crbug.com/678526. Once the bug is fixed, the limitation for WebGL 2.0 and
   // OpenGL ES 3.0 can be lifted.
-  if ((dest_level > 0 && method == DIRECT_DRAW) ||
+  if (((dest_level > 0 || dest_binding_target == GL_TEXTURE_CUBE_MAP) &&
+       method == DIRECT_DRAW) ||
       (source_level > 0 && method == DIRECT_COPY)) {
     method = DRAW_AND_COPY;
   }
 
   if (feature_info_->feature_flags().desktop_srgb_support) {
     bool enable_framebuffer_srgb =
         GetColorEncodingFromInternalFormat(source_internal_format) == GL_SRGB ||
         GetColorEncodingFromInternalFormat(dest_internal_format) == GL_SRGB;
     state_.EnableDisableFramebufferSRGB(enable_framebuffer_srgb);
   }
@@ skipping 2501 matching lines @@
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "base/macros.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu