Use explicit WebString conversions in remaining content files

Use explicit WebString conversions in remaining content files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
Review-Url: https://codereview.chromium.org/2656043002
Cr-Commit-Position: refs/heads/master@{#446615}
Committed: https://chromium.googlesource.com/chromium/src/+/a429302c3d58006f7520aa89e1ae0d3ba1cadc30

[kinuko, 2017-01-26 05:20:42]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 05:21:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-01-26 05:21:36]

Description was changed from

==========
Use explicit WebString conversions in remaining content files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

to

==========
Use explicit WebString conversions in remaining content files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

[kinuko, 2017-01-26 05:21:36]

kinuko@chromium.org changed reviewers:
+ jam@chromium.org

[kinuko, 2017-01-26 05:22:10]

The last remaining ones... could you review?  Mostly mechanical changes only.

[commit-bot: I haz the power, 2017-01-26 05:32:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 05:32:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2017-01-26 07:20:48]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 07:20:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 08:58:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 08:58:44]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jam, 2017-01-26 19:08:10]

lgtm

https://codereview.chromium.org/2656043002/diff/40001/content/child/indexed_d...
File content/child/indexed_db/webidbdatabase_impl_unittest.cc (right):

https://codereview.chromium.org/2656043002/diff/40001/content/child/indexed_d...
content/child/indexed_db/webidbdatabase_impl_unittest.cc:80:
base::string16(kKeySize / sizeof(base::string16::value_type), 'x')));
nit: use the WebString constructor that takes in a char?

[kinuko, 2017-01-27 05:33:02]

Thanks!

https://codereview.chromium.org/2656043002/diff/40001/content/child/indexed_d...
File content/child/indexed_db/webidbdatabase_impl_unittest.cc (right):

https://codereview.chromium.org/2656043002/diff/40001/content/child/indexed_d...
content/child/indexed_db/webidbdatabase_impl_unittest.cc:80:
base::string16(kKeySize / sizeof(base::string16::value_type), 'x')));
On 2017/01/26 19:08:10, jam wrote:
> nit: use the WebString constructor that takes in a char?

It doesn't seem to have a convenient ctor for this particular case, I'll keep as
is in this CL.

[kinuko, 2017-01-27 05:33:08]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-01-27 05:33:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 06:43:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485495188360220,
"parent_rev": "7e02242dcc6044c914b9de1a18cd0d3358769824", "commit_rev":
"a429302c3d58006f7520aa89e1ae0d3ba1cadc30"}

[commit-bot: I haz the power, 2017-01-27 06:44:25]

Description was changed from

==========
Use explicit WebString conversions in remaining content files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

to

==========
Use explicit WebString conversions in remaining content files

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131

Review-Url: https://codereview.chromium.org/2656043002
Cr-Commit-Position: refs/heads/master@{#446615}
Committed:
https://chromium.googlesource.com/chromium/src/+/a429302c3d58006f7520aa89e1ae...
==========

[commit-bot: I haz the power, 2017-01-27 06:44:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a429302c3d58006f7520aa89e1ae...