Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2656043002: Use explicit WebString conversions in remaining content files (Closed)
Patch Set: build fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index e157b372acbc3b142e79eb40c1787d86431a33a0..522bb09ac7cc73a5d8ee87a9b1cbaa63eb7f73bd 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -384,43 +384,43 @@ typedef void (*SetFontFamilyWrapper)(blink::WebSettings*,
void SetStandardFontFamilyWrapper(WebSettings* settings,
const base::string16& font,
UScriptCode script) {
- settings->setStandardFontFamily(font, script);
+ settings->setStandardFontFamily(WebString::fromUTF16(font), script);
}
void SetFixedFontFamilyWrapper(WebSettings* settings,
const base::string16& font,
UScriptCode script) {
- settings->setFixedFontFamily(font, script);
+ settings->setFixedFontFamily(WebString::fromUTF16(font), script);
}
void SetSerifFontFamilyWrapper(WebSettings* settings,
const base::string16& font,
UScriptCode script) {
- settings->setSerifFontFamily(font, script);
+ settings->setSerifFontFamily(WebString::fromUTF16(font), script);
}
void SetSansSerifFontFamilyWrapper(WebSettings* settings,
const base::string16& font,
UScriptCode script) {
- settings->setSansSerifFontFamily(font, script);
+ settings->setSansSerifFontFamily(WebString::fromUTF16(font), script);
}
void SetCursiveFontFamilyWrapper(WebSettings* settings,
const base::string16& font,
UScriptCode script) {
- settings->setCursiveFontFamily(font, script);
+ settings->setCursiveFontFamily(WebString::fromUTF16(font), script);
}
void SetFantasyFontFamilyWrapper(WebSettings* settings,
const base::string16& font,
UScriptCode script) {
- settings->setFantasyFontFamily(font, script);
+ settings->setFantasyFontFamily(WebString::fromUTF16(font), script);
}
void SetPictographFontFamilyWrapper(WebSettings* settings,
const base::string16& font,
UScriptCode script) {
- settings->setPictographFontFamily(font, script);
+ settings->setPictographFontFamily(WebString::fromUTF16(font), script);
}
// If |scriptCode| is a member of a family of "similar" script codes, returns
@@ -1416,7 +1416,8 @@ WebView* RenderViewImpl::createView(WebLocalFrame* creator,
params->window_container_type = WindowFeaturesToContainerType(features);
params->session_storage_namespace_id = session_storage_namespace_id_;
if (frame_name != "_blank")
- params->frame_name = base::UTF16ToUTF8(base::StringPiece16(frame_name));
+ params->frame_name = frame_name.utf8(
+ WebString::UTF8ConversionMode::kStrictReplacingErrorsWithFFFD);
params->opener_url = creator->document().url();
// The browser process uses the top frame's URL for a content settings check
@@ -1624,8 +1625,8 @@ void RenderViewImpl::showValidationMessage(
blink::WebTextDirection main_text_hint,
const blink::WebString& sub_text,
blink::WebTextDirection sub_text_hint) {
- base::string16 wrapped_main_text = main_text;
- base::string16 wrapped_sub_text = sub_text;
+ base::string16 wrapped_main_text = main_text.utf16();
+ base::string16 wrapped_sub_text = sub_text.utf16();
SetValidationMessageDirection(
&wrapped_main_text, main_text_hint, &wrapped_sub_text, sub_text_hint);
@@ -2099,7 +2100,7 @@ void RenderViewImpl::OnEnumerateDirectoryResponse(
WebVector<WebString> ws_file_names(paths.size());
for (size_t i = 0; i < paths.size(); ++i)
- ws_file_names[i] = paths[i].AsUTF16Unsafe();
+ ws_file_names[i] = blink::FilePathToWebString(paths[i]);
enumeration_completions_[id]->didChooseFile(ws_file_names);
enumeration_completions_.erase(id);

Powered by Google App Engine
This is Rietveld 408576698