Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: content/renderer/savable_resources.cc

Issue 2656043002: Use explicit WebString conversions in remaining content files (Closed)
Patch Set: build fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/savable_resources.cc
diff --git a/content/renderer/savable_resources.cc b/content/renderer/savable_resources.cc
index cb21161472ae07c949dcd4ab368624cf360a23ba..395b1f7b007fbd8a3ae8fc438843bb4dbc3ad08e 100644
--- a/content/renderer/savable_resources.cc
+++ b/content/renderer/savable_resources.cc
@@ -150,10 +150,12 @@ WebString GetSubResourceLinkFromElement(const WebElement& element) {
attribute_name = "data";
} else if (element.hasHTMLTagName("link")) {
// If the link element is not linked to css, ignore it.
- if (base::LowerCaseEqualsASCII(
- base::StringPiece16(element.getAttribute("type")), "text/css") ||
- base::LowerCaseEqualsASCII(
- base::StringPiece16(element.getAttribute("rel")), "stylesheet")) {
+ WebString type = element.getAttribute("type");
+ WebString rel = element.getAttribute("rel");
+ if ((type.containsOnlyASCII() &&
+ base::LowerCaseEqualsASCII(type.ascii(), "text/css")) ||
+ (rel.containsOnlyASCII() &&
+ base::LowerCaseEqualsASCII(rel.ascii(), "stylesheet"))) {
// TODO(jnd): Add support for extracting links of sub-resources which
// are inside style-sheet such as @import, url(), etc.
// See bug: http://b/issue?id=1111667.

Powered by Google App Engine
This is Rietveld 408576698