Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2655723002: [Video, Android] Pause video only players ignoring duration and keyframes (Closed)

Created:
3 years, 11 months ago by whywhat
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Video, Android] Pause video only players ignoring duration and keyframes My recent change https://codereview.chromium.org/2631633003 enabled playing background video-only players on Android if they meet various criteria like being shorter than an experimental limit or having frequent enough keyframes. Restore pausing logic by bypassing the irrelevant checks on Android. BUG=None TEST=Manual + updated unit tests Review-Url: https://codereview.chromium.org/2643033004 Cr-Commit-Position: refs/heads/master@{#445116} (cherry picked from commit ac1a85217d72b0043dfb41b447afe4f05d0d5588) Review-Url: https://codereview.chromium.org/2655723002 . Cr-Commit-Position: refs/branch-heads/2987@{#57} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/47a2344d1df3addf7290e5d7ca4640f83e75d134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
whywhat
3 years, 11 months ago (2017-01-24 17:53:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
47a2344d1df3addf7290e5d7ca4640f83e75d134.

Powered by Google App Engine
This is Rietveld 408576698