[Video, Android] Pause video only players ignoring duration and keyframes

media/blink/webmediaplayer_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <stdint.h>
 
 #include <memory>
 
@@ skipping 719 matching lines @@
 
   // Audible video.
   SetMetadata(true, true);
   EXPECT_TRUE(IsBackgroundOptimizationCandidate());
   EXPECT_FALSE(ShouldDisableVideoWhenHidden());
   EXPECT_FALSE(ShouldPauseVideoWhenHidden());
 
   // Video only (pausing is enabled on Android).
   SetMetadata(false, true);
   EXPECT_TRUE(IsBackgroundOptimizationCandidate());
+  EXPECT_FALSE(ShouldDisableVideoWhenHidden());
 #if defined(OS_ANDROID)
   EXPECT_TRUE(ShouldPauseVideoWhenHidden());
+
+  // On Android, the duration and keyframe distance don't matter for video-only.
+  SetDuration(base::TimeDelta::FromSeconds(5));
+  EXPECT_TRUE(IsBackgroundOptimizationCandidate());
+  EXPECT_TRUE(ShouldPauseVideoWhenHidden());
+
+  SetVideoKeyframeDistanceAverage(base::TimeDelta::FromSeconds(100));
+  SetDuration(base::TimeDelta::FromSeconds(300));
+  EXPECT_TRUE(IsBackgroundOptimizationCandidate());
+  EXPECT_TRUE(ShouldPauseVideoWhenHidden());
+
+  // Restore average keyframe distance.
+  SetVideoKeyframeDistanceAverage(base::TimeDelta::FromSeconds(5));
 #else
   EXPECT_FALSE(ShouldPauseVideoWhenHidden());
 #endif
-  EXPECT_FALSE(ShouldDisableVideoWhenHidden());
 
   // Audio only.
   SetMetadata(true, false);
   EXPECT_FALSE(IsBackgroundOptimizationCandidate());
   EXPECT_FALSE(ShouldPauseVideoWhenHidden());
   EXPECT_FALSE(ShouldDisableVideoWhenHidden());
 
   // Duration is shorter than max video keyframe distance.
   SetDuration(base::TimeDelta::FromSeconds(5));
   SetMetadata(true, true);
   EXPECT_TRUE(IsBackgroundOptimizationCandidate());
   EXPECT_FALSE(ShouldPauseVideoWhenHidden());
   EXPECT_FALSE(ShouldDisableVideoWhenHidden());
 
   // Average keyframe distance is too big.
   SetVideoKeyframeDistanceAverage(base::TimeDelta::FromSeconds(100));
   SetDuration(base::TimeDelta::FromSeconds(300));
   EXPECT_FALSE(IsBackgroundOptimizationCandidate());
   EXPECT_FALSE(ShouldPauseVideoWhenHidden());
   EXPECT_FALSE(ShouldDisableVideoWhenHidden());
 }
 
 }  // namespace media