Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 2643033004: [Video, Android] Pause video only players ignoring duration and keyframes (Closed)

Created:
3 years, 11 months ago by whywhat
Modified:
3 years, 11 months ago
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Video, Android] Pause video only players ignoring duration and keyframes My recent change https://codereview.chromium.org/2631633003 enabled playing background video-only players on Android if they meet various criteria like being shorter than an experimental limit or having frequent enough keyframes. Restore pausing logic by bypassing the irrelevant checks on Android. BUG=None TEST=Manual + updated unit tests Review-Url: https://codereview.chromium.org/2643033004 Cr-Commit-Position: refs/heads/master@{#445116} Committed: https://chromium.googlesource.com/chromium/src/+/ac1a85217d72b0043dfb41b447afe4f05d0d5588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 1 chunk +14 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
whywhat
3 years, 11 months ago (2017-01-20 00:49:11 UTC) #2
whywhat
PTaL
3 years, 11 months ago (2017-01-20 00:49:17 UTC) #3
whywhat
3 years, 11 months ago (2017-01-20 17:59:47 UTC) #9
DaleCurtis
lgtm
3 years, 11 months ago (2017-01-20 18:21:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643033004/1
3 years, 11 months ago (2017-01-20 18:54:24 UTC) #12
sandersd (OOO until July 31)
lgtm
3 years, 11 months ago (2017-01-20 19:01:19 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:04:03 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac1a85217d72b0043dfb41b447af...

Powered by Google App Engine
This is Rietveld 408576698