Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2655463009: aura-mus: Implement DesktopWindowTreeHostMus::StackAbove(). (Closed)

Created:
3 years, 11 months ago by Elliot Glaysher
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aura-mus: Implement DesktopWindowTreeHostMus::StackAbove(). Adds API to the window server and the window manager so that a client can request that one of their roots owned by the window manager can be placed above another one of their roots owned by the window manager. BUG=663617 Review-Url: https://codereview.chromium.org/2655463009 Cr-Commit-Position: refs/heads/master@{#446409} Committed: https://chromium.googlesource.com/chromium/src/+/bc615bd3f80accc95a7ff9da81e80a6420479bb0

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Fix comment grammar. #

Patch Set 4 : Merge with tot #

Total comments: 1

Patch Set 5 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -3 lines) Patch
M services/ui/public/interfaces/window_manager.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M services/ui/public/interfaces/window_tree.mojom View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M services/ui/ws/access_policy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/default_access_policy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/default_access_policy.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M services/ui/ws/test_utils.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M services/ui/ws/window_manager_access_policy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/ws/window_manager_access_policy.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_tree.cc View 1 2 2 chunks +61 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 2 chunks +47 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_host_mus_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/aura/test/mus/test_window_tree.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/test/mus/test_window_tree.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus.cc View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download
M ui/views/mus/desktop_window_tree_host_mus_unittest.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Elliot Glaysher
3 years, 11 months ago (2017-01-26 00:02:56 UTC) #9
sky
LGTM https://codereview.chromium.org/2655463009/diff/60001/services/ui/public/interfaces/window_tree.mojom File services/ui/public/interfaces/window_tree.mojom (right): https://codereview.chromium.org/2655463009/diff/60001/services/ui/public/interfaces/window_tree.mojom#newcode267 services/ui/public/interfaces/window_tree.mojom:267: // Stacks the window |above_id| above |below_id|. Please ...
3 years, 11 months ago (2017-01-26 00:48:11 UTC) #15
Elliot Glaysher
+tsepez: mojom review. Like yesterday, the ids in window_manager.mojom are only shared between the window ...
3 years, 11 months ago (2017-01-26 00:50:22 UTC) #17
Tom Sepez
Mojom LGTM, thanks for the clarification.
3 years, 11 months ago (2017-01-26 17:25:22 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655463009/80001
3 years, 11 months ago (2017-01-26 18:02:43 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 19:56:10 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/bc615bd3f80accc95a7ff9da81e8...

Powered by Google App Engine
This is Rietveld 408576698